G.Ambatte
5e35ae0c8b
Merge branch 'master' into addDBCheckMiddleware
2025-10-06 18:12:40 +13:00
Trevor Buckner
5f72dd2023
Merge pull request #4462 from naturalcrit/PreventInterruptedBrewJump
...
Move badly-placed scrollingTimeout that was doing nothing
2025-10-06 00:07:50 -04:00
Trevor Buckner
7fc03bb5a7
Merge branch 'master' into PreventInterruptedBrewJump
2025-10-06 00:07:43 -04:00
Trevor Buckner
ccf11661de
Merge pull request #4461 from naturalcrit/LintEverythingOct2025
...
Lint everything
2025-10-06 00:07:29 -04:00
Trevor Buckner
811f274968
Move badly-placed scrollingTimeout that was doing nothing
...
When a user clicks brewJump or sourceJump, we disallow new jumps until the current scroll operation has finished for 150 ms. Unfortunately the timer being checked was always undefined, so you could keep clicking the jump button and get the brewRenderer or editor to keep bouncing around without finishing the jump action.
This just moves the scrollingTimeout up outside of the listener function so it isn't being reset to undefined every loop.
2025-10-06 00:06:34 -04:00
Trevor Buckner
63bebe1efd
Lint everything
...
Catching up on a bunch of linting so random changes stop showing up on PRs when the linter is run.
2025-10-06 00:02:24 -04:00
G.Ambatte
8b2c8c0feb
Merge branch 'master' into addDBCheckMiddleware
2025-10-06 16:48:37 +13:00
Trevor Buckner
22e26d635a
Merge pull request #4460 from naturalcrit/cleanupLocalStorageKeysTest
...
Clean up localStorageMap code
2025-10-05 23:28:34 -04:00
Trevor Buckner
643e0ac650
small cleanups of localstorage keys code
2025-10-05 23:24:50 -04:00
Trevor Buckner
5395412ac5
Remove tests for getLocalStorageMap()
...
The function is a simple getter with trivial logic; test is effectively just asserting the size of the map, which coverage adds no meaningful value and adds cruft to the codebase.
2025-10-05 23:24:35 -04:00
Trevor Buckner
dc4610ea1b
Merge pull request #4447 from dbolack-ab/issue_3426
...
Applies G-Ambatte's fix for Firefox browser lock.
2025-10-05 22:31:15 -04:00
Trevor Buckner
1e71e9e18a
Use blockquote and table elements, not .classes
2025-10-05 22:19:43 -04:00
Trevor Buckner
4203e90d09
Merge branch 'master' into issue_3426
2025-10-05 22:09:06 -04:00
Trevor Buckner
dc94555c94
Merge pull request #4458 from naturalcrit/new/edit/home_commonSaveButton
...
Make the renderSaveButton() function common between edit/new/home
2025-10-05 22:03:32 -04:00
Trevor Buckner
41aebf084b
Make the renderSaveButton() function common between edit/new/home
...
Each of the edit/home/new pages renders its save button differently. This makes it a common function with all the same possible render states (does the document have unsaved changes? Is it already saved? Was it auto-saved?).
- Common save button
- Adds the "save" button to /home page which wasn't there before
- Animates the "save" button in /home and /new when the user makes their first change to signal that yes, you do have to actually click the save button if you want to keep this.
- "reminder... you haven't saved for X minutes" still not functional on /new and /home since that involves more moving pieces.
2025-10-05 21:57:19 -04:00
David Bolack
74e17e154f
Merge branch 'issue_3426' of github.com:dbolack-ab/homebrewery into issue_3426
2025-10-05 20:12:32 -05:00
Trevor Buckner
a944b23ca0
Merge pull request #4457 from naturalcrit/new/home/edit/_unsavedChanges_common
...
Make `unsavedChanges` state common
2025-10-05 20:09:14 -04:00
Trevor Buckner
12052853db
Merge branch 'master' into new/home/edit/_unsavedChanges_common
2025-10-05 20:07:56 -04:00
Trevor Buckner
c0f67bef5a
Merge pull request #4434 from naturalcrit/fix-red-background
...
Fix dev background
2025-10-05 19:51:01 -04:00
David Bolack
8f715a6615
Isolate change to Firefox
2025-10-05 18:36:14 -05:00
Víctor Losada Hernández
1f51abaf10
this makes more sense
2025-10-05 19:57:49 +02:00
Víctor Losada Hernández
c90a8c53a5
lets test this
2025-10-05 19:56:50 +02:00
Víctor Losada Hernández
ac18f4bd1d
Merge branch 'master' of https://github.com/naturalcrit/homebrewery into fix-red-background
2025-10-05 19:43:29 +02:00
Víctor Losada Hernández
7393aef806
set up development config variavle
2025-10-05 19:42:01 +02:00
G.Ambatte
c17a5e72b9
Switch to Calc's simplified test spec
2025-10-05 15:40:40 +13:00
G.Ambatte
88bc9b79c9
Add new error message to nav bar error container
2025-10-05 15:31:53 +13:00
G.Ambatte
a14ea89562
Post-merge cleanup
2025-10-05 15:31:04 +13:00
G.Ambatte
bb0a840113
Fix HBErrorCode to string, not number
2025-10-05 15:30:47 +13:00
Trevor Buckner
2c4c4b8f92
Make unsavedChanges state common
...
/editPage.jsx uses `unsavedChanges` state to detect when autosave should fire, or unsaved changes warning should display.
/homePage.jsx uses a similar check (different variables) to detect when to show the popup "save now"! button
/newPage.jsx doesn't do any of this, but probably should pop up a warning when saving hasn't happened for a long time
This commit just gives all of the pages the same common `unsavedChanges` state, calculated in the same way, and updates any sections that depend on that updated state.
This is precursor work to adding "unsaved changes" warnings to all three pages.
2025-10-04 22:17:24 -04:00
G.Ambatte
d40f8ff380
Merge branch 'master' into addDBCheckMiddleware
2025-10-05 14:58:56 +13:00
Trevor Buckner
c751d647d9
Merge pull request #4440 from naturalcrit/UnifyNewHomeEdit-Structure&Naming
...
Clean Up Common features of new/home/edit
2025-10-04 21:52:28 -04:00
Trevor Buckner
6057b35d19
Merge branch 'master' into UnifyNewHomeEdit-Structure&Naming
2025-10-04 21:48:10 -04:00
Trevor Buckner
521d42f32f
Merge pull request #4455 from G-Ambatte/enableOldKeyDeletion
...
Permanently enable old local storage key deletion
2025-10-04 21:47:21 -04:00
Trevor Buckner
e9f8302597
Merge branch 'master' into enableOldKeyDeletion
2025-10-04 21:47:06 -04:00
Trevor Buckner
f429b1755d
Merge pull request #4456 from naturalcrit/RemoveHandlePageChangeWrappers
...
Remove handler function for cursor/renderer page. Use setState directly
2025-10-04 21:46:32 -04:00
Trevor Buckner
20e12ebcb5
Remove handler function for cursor/renderer page. Use setState directly
2025-10-04 21:39:24 -04:00
G.Ambatte
ae51213c8c
Permanently enable old local storage key deletion
2025-10-05 12:25:51 +13:00
Trevor Buckner
8f7ae35f08
Merge branch 'master' into issue_3426
2025-10-04 18:32:15 -04:00
Trevor Buckner
44023f390c
Merge pull request #4453 from G-Ambatte/fixDockerInstructionsForWindows-#4443
...
Add Windows-specific instructions to Docker README
2025-10-04 18:02:47 -04:00
Trevor Buckner
48b95712e2
Merge branch 'master' into fixDockerInstructionsForWindows-#4443
2025-10-04 18:01:58 -04:00
Trevor Buckner
16c28e16ce
Merge pull request #4452 from G-Ambatte/standardizeLocalStorageKeyNames-#4119
...
Standardize local storage key names #4119
2025-10-04 17:54:10 -04:00
G.Ambatte
379b518c6b
Merge branch 'master' into fixDockerInstructionsForWindows-#4443
2025-10-04 15:40:03 +13:00
G.Ambatte
962dcbdbf6
Update Docker instructions
2025-10-04 15:36:14 +13:00
G.Ambatte
400fa250ee
Move key deletion out of key update check
2025-10-04 15:19:31 +13:00
G.Ambatte
e82921f81a
Add key to activate deletion for testing
2025-10-04 14:54:57 +13:00
G.Ambatte
18367526bd
Merge branch 'master' into standardizeLocalStorageKeyNames-#4119
2025-10-04 13:07:51 +13:00
David Bolack
f0bb06e706
Merge branch 'master' into issue_3426
2025-10-03 18:52:56 -05:00
G.Ambatte
2b138e56db
Add dbCheck middleware to app.js routes that use DB
2025-10-04 12:29:06 +13:00
Víctor Losada Hernández
aff9a85769
end of file character shit
2025-10-03 21:38:43 +02:00
Víctor Losada Hernández
e0379a0baa
last cleanup
2025-10-03 21:38:10 +02:00
