Trevor Buckner
0632d78f71
Remove toolbar checks for empty visiblePages list
...
With `centerPage`, ToolBar will never receive an empty visiblePages array. No need to check if visiblepages.length == 0
2024-12-24 00:18:37 -05:00
Trevor Buckner
c0155052ea
Further simplifying
2024-12-24 00:06:30 -05:00
Trevor Buckner
628b2542a0
Simplify logic for previous/next buttons
2024-12-24 00:02:55 -05:00
Trevor Buckner
85f1da942f
Restore looping over entries. Needed for very fast scrolling
2024-12-23 23:08:30 -05:00
Trevor Buckner
3909d5aef9
remove unused iFrameRef
...
iFrameRef is not used anywhere
2024-12-23 22:48:57 -05:00
Trevor Buckner
f0e047e7cc
Remove loop on intersectionObserver entries
...
Guaranteed to only be one entry each time, since we are attaching each page to its own observers.
2024-12-23 22:43:37 -05:00
Trevor Buckner
d588a92147
Change page range to only display a single range
...
Having multiple page ranges visible is a weird edge case that only happens in two-page view. Simplifying logic to just group all page ranges together if a middle page is partly obscured.
2024-12-23 18:37:20 -05:00
Trevor Buckner
2b7a1e1cb2
Reduce overlapping observer handlers
...
Combine handlePageVisibilityChange and handleCenterPageChange to reduce some of the infrastructure burden for handling centerPage.
2024-12-23 18:35:36 -05:00
Trevor Buckner
c8efca3120
useCallBack is not needed here.
2024-12-23 17:22:50 -05:00
Trevor Buckner
a53eacf055
remove CenterPage from ToolBar props
...
centerPage is not used in the toolbar component.
2024-12-23 17:17:13 -05:00
Trevor Buckner
1b10a4001a
Merge branch 'master' into pr/3845
2024-12-23 11:37:40 -05:00
Trevor Buckner
75e71dd6f5
Merge pull request #3960 from G-Ambatte/addGoogleRefreshInfoToErrorPage-#3955
...
Add google refresh info to error page #3955
2024-12-22 22:31:31 -05:00
Trevor Buckner
3f87b9f7d3
Merge branch 'master' into addGoogleRefreshInfoToErrorPage-#3955
2024-12-22 22:30:04 -05:00
Trevor Buckner
32561cf368
Moving to just HBErrorCode 01
...
02 is specifically for 404 errors when the file is actually missing. In that case, refreshing credentials probably won't work. (We should update the errorNav to make this distinction as well.)
2024-12-22 22:19:02 -05:00
Trevor Buckner
bf94cdcb6f
Merge pull request #3961 from naturalcrit/toWellFormedPolyfill
...
Use project babel config for buildHomebrew script
2024-12-22 21:39:14 -05:00
Trevor Buckner
e8eedcf6d6
Import polyfill from core-js
...
Possible to have babel automatically detect and import polyfills as needed, but Browserify just can't handle it. Manually importing the one troublesome one into the root of our project.
2024-12-22 21:32:30 -05:00
Trevor Buckner
92d1238a46
Use project babel config for buildHomebrew script
...
Jest uses the babel.config file already. Might as well all use the same config.
2024-12-22 21:31:31 -05:00
G.Ambatte
fcfd3171bd
Tweak start of instructions
2024-12-22 18:00:27 +13:00
G.Ambatte
9a6cf8c5d2
Linter fix
2024-12-22 17:53:14 +13:00
G.Ambatte
91d928fd8a
End list properly
2024-12-22 17:52:58 +13:00
G.Ambatte
bca653bc4d
Add instructions to HBErrorCode 01 & 02
2024-12-22 17:52:09 +13:00
Trevor Buckner
dceb5e516b
Merge pull request #3909 from dbolack-ab/horizontalSpace
...
V4 proposed non-breaking space token
2024-12-20 15:42:58 -05:00
Trevor Buckner
adb1db1d3c
Revert one more regex change
2024-12-20 15:39:57 -05:00
David Bolack
e8d1e632b4
Merge branch 'master' into horizontalSpace
2024-12-20 14:08:31 -06:00
David Bolack
50fcffb253
Revert exclusion on single definition list regex
...
This permits `Term ::> Definition` to process as a single line definition list
2024-12-20 14:06:20 -06:00
Trevor Buckner
aae5367ad2
Add test case for single-line definition list
2024-12-20 11:01:55 -05:00
Trevor Buckner
40b0c1ce3a
Merge pull request #3957 from naturalcrit/dependabot/npm_and_yarn/eslint-plugin-jest-28.10.0
...
Bump eslint-plugin-jest from 28.9.0 to 28.10.0
2024-12-20 10:38:26 -05:00
dependabot[bot]
ba83dfacd9
Bump eslint-plugin-jest from 28.9.0 to 28.10.0
...
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest ) from 28.9.0 to 28.10.0.
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases )
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md )
- [Commits](https://github.com/jest-community/eslint-plugin-jest/compare/v28.9.0...v28.10.0 )
---
updated-dependencies:
- dependency-name: eslint-plugin-jest
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-12-20 04:26:51 +00:00
Trevor Buckner
2717e6a9a4
Merge pull request #3956 from naturalcrit/dependabot/npm_and_yarn/mongoose-8.9.2
...
Bump mongoose from 8.9.1 to 8.9.2
2024-12-19 23:25:40 -05:00
Trevor Buckner
d576bddd32
Merge pull request #3958 from naturalcrit/Add-missing-test-suites-to-circleci
...
Add emoji tests to circleci
2024-12-19 23:25:26 -05:00
Trevor Buckner
fde21868cd
Add emoji tests to circleci
2024-12-19 23:20:01 -05:00
Trevor Buckner
ed8c4d0eef
Add tests to circleCi
2024-12-19 23:14:32 -05:00
Trevor Buckner
6e9d293bbe
Rename tests to "Non-breaking Spaces"
...
Hard Breaks name was leftover from copying the `::::` test file.
2024-12-19 23:09:43 -05:00
dependabot[bot]
7e1312805f
Bump mongoose from 8.9.1 to 8.9.2
...
Bumps [mongoose](https://github.com/Automattic/mongoose ) from 8.9.1 to 8.9.2.
- [Release notes](https://github.com/Automattic/mongoose/releases )
- [Changelog](https://github.com/Automattic/mongoose/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Automattic/mongoose/compare/8.9.1...8.9.2 )
---
updated-dependencies:
- dependency-name: mongoose
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-12-20 03:38:26 +00:00
David Bolack
d629fa1731
Merge branch 'master' into horizontalSpace
2024-12-19 17:45:51 -06:00
David Bolack
6301a66fd3
Add additional tests
2024-12-19 17:44:48 -06:00
Trevor Buckner
980a7bd57e
Merge pull request #3954 from naturalcrit/dependabot/npm_and_yarn/globals-15.14.0
...
Bump globals from 15.13.0 to 15.14.0
2024-12-18 23:52:01 -05:00
Trevor Buckner
6b0022ad00
Merge branch 'master' into dependabot/npm_and_yarn/globals-15.14.0
2024-12-18 23:22:22 -05:00
Trevor Buckner
0f33973e58
Merge pull request #3953 from G-Ambatte/fixAdminAddedAsAuthor-#3952
...
Fix admin added as author #3952
2024-12-18 23:22:06 -05:00
G.Ambatte
7a41a140fd
Merge branch 'master' into fixAdminAddedAsAuthor-#3952
2024-12-19 17:00:26 +13:00
Trevor Buckner
57467701d0
Fetch Google Brew if only stub requested but nothing found
...
/update/ requests only the stub for updating. But if no stub exists, we should fetch the full brew so we return *something*.
2024-12-18 23:00:01 -05:00
dependabot[bot]
9dbfb26e6c
Bump globals from 15.13.0 to 15.14.0
...
Bumps [globals](https://github.com/sindresorhus/globals ) from 15.13.0 to 15.14.0.
- [Release notes](https://github.com/sindresorhus/globals/releases )
- [Commits](https://github.com/sindresorhus/globals/compare/v15.13.0...v15.14.0 )
---
updated-dependencies:
- dependency-name: globals
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-12-19 03:47:25 +00:00
G.Ambatte
7a169cbd9e
Linter clean up
2024-12-19 16:20:28 +13:00
G.Ambatte
2dc8a8fbe9
Remove req.account from update request
2024-12-19 16:20:04 +13:00
Trevor Buckner
5f14f656ef
Logging
2024-12-18 17:23:38 -05:00
Trevor Buckner
6e8a0d7314
current user owns 0-author brew only if edit mode
...
Previous code was treating /share/ visits to google brews with no stub as visits by owner, thus using their own credentials to open the file instead of serviceaccount
2024-12-18 17:07:09 -05:00
Trevor Buckner
e61144beb8
Mark as owner if stub doesn't exist
...
Old Google Drive files without a stub have no author, so if no stub exists, consider the current user the owner.
2024-12-18 13:45:53 -05:00
Trevor Buckner
64b792c645
Fix case where no stub is found
...
When retrieving a Google Brew with no stub yet, if the user is not logged in or has expired credentials, we enter this error handler. However, the error message itself tries to send a list of authors.
If there was no stub, we crash here with a 500 error.
This adds conditional operator to any stub value so we can send the actual "not logged in" error in case of no stub.
2024-12-18 13:02:14 -05:00
Trevor Buckner
aee5b7a8cc
Require user to be logged in to change name
2024-12-18 12:14:08 -05:00
David Bolack
912f9f0cf6
Remove extraneous linefeeds in horizontalbreaks
2024-12-17 21:40:56 -06:00
