Adds registered custom properties to the dropdown menus, which can be set in another stylesheet at any level (either on the direct element or on an ancestor) or use the default values given.
Adds the `disabled` attribute to a menu-item button if it's disabled, not just as a className. Styling changes centered on that as well.
Also changes the `beta` class to `status` because it is used for both `beta` and `disabled` indicators. Styling changes for that.
The styling in the dropdown.less file targeting `.menu-wrapper` was not doing anything. Double checked on old firefox, too, in case it was needed for oddbird polyfill.
The snippets are a `menubar` in terms of role, and is a list of items (`menitem`, `li`).
Note for myself: submenus are `menu` roles that immediately follow their triggering `menuitem` and are direct children of the parent `menu`, per WCAG. This is done in this commit.
commit e02ce4f898 unintentionally undid some changes for v4 by dbolack, I'm not really sure how. It's evidently not possible to directly "revert" those changes without having a conflicted file, i think something was borked in the process.
manually reverting the changes here, hopefully it works out.
to decrease the width used for the snippet bar triggers, removed the down arrows (for the top level triggers only). And, reduced the padding on the icons in the snippetbar while retaining it inside the menus.
The icons still align between the menu list and the menu trigger, but the text labels do not.
revert commit 1fe19578c2 which changed `anchor()` values to `position-area`.
I'm not sure what compelled me to do that change initially, except the easier to understand syntax. Hopefully it wasn't important.
But oddbird polyfill expects `anchor()` values, which it converts to pixel values for positioning.
This updates the position try results by using a different method of setting the area of the anchored element. Rather than using the inset properties with `anchor()`, it uses `position-area`.
Largely this is written by an LLM after I provided the targets, and I've looked through the tests themselves to confirm they are accurate. There may be improvements in how to actually *set up* the tests, though, as I am less familiar with those.
This has two test suites: the first for html structure, the second for behavior. Each of them calls another script that provides helper functions for setting things up and taking them down. This keeps the test suites themselves fairly lean.
This fixes the odd alignments of menu-wrapper names by ensuring that both menuitems and menu-wrappers (actually their child triggers) both have space for icons.
Unless a menu item has the `no-dismiss` attribute (set to either `''` or `'true'`), clicking a menu item will dismiss the menu. Clicking a submenu trigger will not dismiss the menu.
The `no-dismiss` attribute must take a string, either empty or `'true'` because react doesn't allow boolean custom attributes.
Only 400 and "800" are used in the codebase for Open Sans. And, we've only ever had up to 700 as available weights, so everything that is set to "800" is actually getting weight 700 (which looks better).
Since the print cycle now loads all images not-yet-loaded (due to lazy loading), there can be a moment of time where it appears pressing Get PDF is doing nothing, depending on connection speed. To add a "loading" message, a custom event is fired at the start and end of the print cycle (before the print dialog comes up).
When initiating the print dialog, it first grabs all img elements with `loading="lazy"` attribute, flips that to `eager`, and then waits for every image to load before resolving a promise and opening the Print dialog.
Removes the additional line after a snippet, so it doesn't effectively create a `\n` at the end of the snippet. This allows snippets to be inline with text.
This simply moves the codeEditor folder to the components directory. `codeEditor.jsx` simply builds a component which is then used elsewhere, and isn't shared between client and server, so it should be in the client directory.
Arguably it could go in `client/homebrew/editor` but I think the `/homebrew/` folder should be eliminated down the line and it's contents just re-sorted.
When working on the editor right now it's a pain to switch between `shared` and `client` hunting for the right file.
Move the SVGs out of the `shared` directory, closer to where they are actually used. They are svg jsx files, setup as components, so i've moved them to the components directory.
Deleted `combat.svg.jsx` because we don't use it anywhere.
renamed the remaining two to be more descriptive of the image for additional clarity.
Moving this component to the component folder so it's closer to where it is actually used. Not moving to the `homebrew` folder because ultimately i think pretty much everything in that folder should move to the components as well (`homebrew` isn't a helpful folder distinction).
Deletes a directory, moves 2 files.
Making some changes to the reset.less so that some default UA button styling is removed.
Then, changing core.less so that the classic "HB" button styling is scoped to a certain class `.colorButton`. This will make it easier to use the button element in other places.
When the page is zoomed in very close, such that <30% of the page is in view, it doesn't register changes to the 'current page'. This fixes that, passing in the 'centerPage' if 'visiblePages' is empty.
I don't love this fix, i think the visiblePages should always have *something* in it, but I can't quite figure out how to set that (since the normal update to visiblePages is happening in an observer that doesn't fire if nothing is in view).
Gazook89