f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-11 11:12:44 +00:00
Code Wiki Activity

Remove unneeded dependencies for useEffect

Browse Source 
UseEffect is only intended to be called once.

Similarly, handleControlKeys doesn't need "useCallBack" because it will never be passed to a child or trigger any re-render by changing.
This commit is contained in:
Trevor Buckner
2024-12-26 19:09:23 -05:00
parent e2b0da7830
commit 9804c3933f
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
client/homebrew/pages/sharePage/sharePage.jsx
View File

@@ -26,7 +26,7 @@ const SharePage = (props)=>{
updateState({ currentBrewRendererPageNum: pageNumber }); updateState({ currentBrewRendererPageNum: pageNumber });
}, []); }, []);
const handleControlKeys = useCallback((e)=>{ const handleControlKeys = (e)=>{
if(!(e.ctrlKey || e.metaKey)) return; if(!(e.ctrlKey || e.metaKey)) return;
const P_KEY = 80; const P_KEY = 80;
if(e.keyCode === P_KEY) { if(e.keyCode === P_KEY) {
@@ -34,14 +34,12 @@ const SharePage = (props)=>{
e.stopPropagation(); e.stopPropagation();
e.preventDefault(); e.preventDefault();
} }
}, []); };
useEffect(()=>{ useEffect(()=>{
document.addEventListener('keydown', handleControlKeys); document.addEventListener('keydown', handleControlKeys);
fetchThemeBundle( fetchThemeBundle(
{ { setState },
setState,
},
brew.renderer, brew.renderer,
brew.theme brew.theme
); );
@@ -49,7 +47,7 @@ const SharePage = (props)=>{
return ()=>{ return ()=>{
document.removeEventListener('keydown', handleControlKeys); document.removeEventListener('keydown', handleControlKeys);
}; };
}, [brew.renderer, brew.theme, handleControlKeys]); }, []);
const processShareId = useCallback(()=>{ const processShareId = useCallback(()=>{
return brew.googleId && !brew.stubbed ? brew.googleId + brew.shareId : brew.shareId; return brew.googleId && !brew.stubbed ? brew.googleId + brew.shareId : brew.shareId;