From 9804c3933f4de63298d4e0a293336cb5d8eb2e66 Mon Sep 17 00:00:00 2001
From: Trevor Buckner <calculuschild@gmail.com>
Date: Thu, 26 Dec 2024 19:09:23 -0500
Subject: [PATCH] Remove unneeded dependencies for useEffect

UseEffect is only intended to be called once.

Similarly, handleControlKeys doesn't need "useCallBack" because it will never be passed to a child or trigger any re-render by changing.
---
 client/homebrew/pages/sharePage/sharePage.jsx | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/client/homebrew/pages/sharePage/sharePage.jsx b/client/homebrew/pages/sharePage/sharePage.jsx
index b561ead3f..439c38d6a 100644
--- a/client/homebrew/pages/sharePage/sharePage.jsx
+++ b/client/homebrew/pages/sharePage/sharePage.jsx
@@ -26,7 +26,7 @@ const SharePage = (props)=>{
 		updateState({ currentBrewRendererPageNum: pageNumber });
 	}, []);
 
-	const handleControlKeys = useCallback((e)=>{
+	const handleControlKeys = (e)=>{
 		if(!(e.ctrlKey || e.metaKey)) return;
 		const P_KEY = 80;
 		if(e.keyCode === P_KEY) {
@@ -34,14 +34,12 @@ const SharePage = (props)=>{
 			e.stopPropagation();
 			e.preventDefault();
 		}
-	}, []);
+	};
 
 	useEffect(()=>{
 		document.addEventListener('keydown', handleControlKeys);
 		fetchThemeBundle(
-			{
-				setState,
-			},
+			{ setState },
 			brew.renderer,
 			brew.theme
 		);
@@ -49,7 +47,7 @@ const SharePage = (props)=>{
 		return ()=>{
 			document.removeEventListener('keydown', handleControlKeys);
 		};
-	}, [brew.renderer, brew.theme, handleControlKeys]);
+	}, []);
 
 	const processShareId = useCallback(()=>{
 		return brew.googleId && !brew.stubbed ? brew.googleId + brew.shareId : brew.shareId;