f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2025-12-24 18:32:41 +00:00
Code Wiki Activity

move back to conditional showing instead of conditional rendering

Browse Source
This commit is contained in:
Víctor Losada Hernández
2024-10-10 13:17:24 +02:00
parent 001bf4a605
commit 2d8874acaf
2 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
client/components/dialog.jsx
View File

@@ -6,13 +6,10 @@ function Dialog({ dismissKeys, closeText = 'Close', blocking = false, ...rest })
const dialogRef = useRef(null);
useEffect(()=>{
blocking ? dialogRef.current?.showModal() : dialogRef.current?.show();
}, [dialogRef.current]);
console.log(dismissKeys);
if (dismissKeys.length === 0) {
return null;
}
if (dismissKeys.length !== 0) {
blocking ? dialogRef.current?.showModal() : dialogRef.current?.show();
}
}, [dialogRef.current, dismissKeys]);
const dismiss = () => {
dismissKeys.forEach(key => {
@@ -22,7 +19,7 @@ function Dialog({ dismissKeys, closeText = 'Close', blocking = false, ...rest })
});
dialogRef.current?.close();
};
console.log('rendering');
return (
<dialog ref={dialogRef} onCancel={dismiss} {...rest}>
{rest.children}

1
client/homebrew/brewRenderer/notificationPopup/notificationPopup.jsx
View File

@@ -22,7 +22,6 @@ const NotificationPopup = ()=>{
try {
const res = await request.get('/admin/notification/all');
console.log('res', res.body);
pickActiveNotifications(res.body || []);
} catch (err) {
console.log(err);