f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-10 17:52:47 +00:00
Code Wiki Activity

Fix "clicked on the toggle ring" crash with scroll lock.

Browse Source 
The code was doing dom-climbing math based on clicking on the div contents but was attached to the div. Moved the onClick to the contents.
This commit is contained in:
David Bolack
2024-09-07 22:36:27 -05:00
parent fa74fb4ada
commit 1e9c7423c7
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
client/homebrew/editor/editor.jsx
View File

@@ -121,6 +121,7 @@ const Editor = createClass({
const RIGHTARROW_KEY = 39; const RIGHTARROW_KEY = 39;
if(this.props.liveScroll) { if(this.props.liveScroll) {
console.log('Should be scrollig!');
const movementKeys = [13, 33, 34, LEFTARROW_KEY, 38, RIGHTARROW_KEY, 40]; const movementKeys = [13, 33, 34, LEFTARROW_KEY, 38, RIGHTARROW_KEY, 40];
if(movementKeys.includes(e.keyCode)) { if(movementKeys.includes(e.keyCode)) {
const curPage = this.getCurrentPage(); const curPage = this.getCurrentPage();

5
shared/naturalcrit/splitPane/splitPane.jsx
View File

@@ -153,9 +153,8 @@ const SplitPane = createClass({
<i className='fas fa-arrow-right' /> <i className='fas fa-arrow-right' />
</div> </div>
<div id='scrollToggleDiv' className={`arrow lock`} <div id='scrollToggleDiv' className={`arrow lock`}
style={{ left: this.state.currentDividerPos-4 }} style={{ left: this.state.currentDividerPos-4 }} >
onClick={this.liveScrollToggle} > <i id='scrollToggle' className={`fas fa-lock`} onClick={this.liveScrollToggle}/>
<i id='scrollToggle' className={`fas fa-lock`} />
</div> </div>
</>; </>;
} }