From 1e9c7423c77bac5c53a8b34c05df59616e6f8837 Mon Sep 17 00:00:00 2001
From: David Bolack <dbolack@gmail.com>
Date: Sat, 7 Sep 2024 22:36:27 -0500
Subject: [PATCH] Fix "clicked on the toggle ring" crash with scroll lock.

The code was doing dom-climbing math based on clicking on the div contents but was attached to the div. Moved the onClick to the contents.
---
 client/homebrew/editor/editor.jsx          | 1 +
 shared/naturalcrit/splitPane/splitPane.jsx | 5 ++---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/client/homebrew/editor/editor.jsx b/client/homebrew/editor/editor.jsx
index ffeed00b0..1fa720f81 100644
--- a/client/homebrew/editor/editor.jsx
+++ b/client/homebrew/editor/editor.jsx
@@ -121,6 +121,7 @@ const Editor = createClass({
 		const RIGHTARROW_KEY = 39;
 
 		if(this.props.liveScroll) {
+			console.log('Should be scrollig!');
 			const movementKeys = [13, 33, 34, LEFTARROW_KEY, 38, RIGHTARROW_KEY, 40];
 			if(movementKeys.includes(e.keyCode)) {
 				const curPage = this.getCurrentPage();
diff --git a/shared/naturalcrit/splitPane/splitPane.jsx b/shared/naturalcrit/splitPane/splitPane.jsx
index 21d95f2c5..4d9dd452b 100644
--- a/shared/naturalcrit/splitPane/splitPane.jsx
+++ b/shared/naturalcrit/splitPane/splitPane.jsx
@@ -153,9 +153,8 @@ const SplitPane = createClass({
 					<i className='fas fa-arrow-right' />
 				</div>
 				<div id='scrollToggleDiv' className={`arrow lock`}
-					style={{ left: this.state.currentDividerPos-4 }}
-					onClick={this.liveScrollToggle} >
-					<i id='scrollToggle' className={`fas fa-lock`} />
+					style={{ left: this.state.currentDividerPos-4 }} >
+					<i id='scrollToggle' className={`fas fa-lock`} onClick={this.liveScrollToggle}/>
 				</div>
 			</>;
 		}