f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2025-12-31 08:42:40 +00:00
Code Wiki Activity

Eliminate unnecessary window.frames calls

Browse Source
This commit is contained in:
G.Ambatte
2022-06-04 17:09:25 +12:00
parent 4e8cbf621b
commit 1d0cceda04
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
client/homebrew/editor/editor.jsx
View File

@@ -190,7 +190,8 @@ const Editor = createClass({
brewJump : function(targetPage=this.getCurrentPage()){ brewJump : function(targetPage=this.getCurrentPage()){
if(!window || this.isMeta()) return; if(!window || this.isMeta()) return;
// console.log(`Scroll to: p${targetPage}`); // console.log(`Scroll to: p${targetPage}`);
const currentPos = window.frames['BrewRenderer'].contentDocument.getElementsByClassName('brewRenderer')[0].scrollTop; const brewRenderer = window.frames['BrewRenderer'].contentDocument.getElementsByClassName('brewRenderer')[0];
const currentPos = brewRenderer.scrollTop;
const targetPos = window.frames['BrewRenderer'].contentDocument.getElementById(`p${targetPage}`).getBoundingClientRect().top; const targetPos = window.frames['BrewRenderer'].contentDocument.getElementById(`p${targetPage}`).getBoundingClientRect().top;
const interimPos = targetPos >= 0 ? -30 : 30; const interimPos = targetPos >= 0 ? -30 : 30;
@@ -201,9 +202,9 @@ const Editor = createClass({
this.setState({ this.setState({
isBrewScrolling : true isBrewScrolling : true
}); });
window.frames['BrewRenderer'].contentDocument.getElementsByClassName('brewRenderer')[0].scrollTo({ top: currentPos + interimPos, behavior: 'smooth' }); brewRenderer.scrollTo({ top: currentPos + interimPos, behavior: 'smooth' });
setTimeout(()=>{ setTimeout(()=>{
window.frames['BrewRenderer'].contentDocument.getElementsByClassName('brewRenderer')[0].scrollTo({ top: currentPos + targetPos, behavior: 'smooth', block: 'start' }); brewRenderer.scrollTo({ top: currentPos + targetPos, behavior: 'smooth', block: 'start' });
}, bounceDelay); }, bounceDelay);
setTimeout(()=>{ setTimeout(()=>{
this.setState({ this.setState({