From 1d0cceda044fc2e89d4ea966a407edcfbb5c2600 Mon Sep 17 00:00:00 2001 From: "G.Ambatte" Date: Sat, 4 Jun 2022 17:09:25 +1200 Subject: [PATCH] Eliminate unnecessary `window.frames` calls --- client/homebrew/editor/editor.jsx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/client/homebrew/editor/editor.jsx b/client/homebrew/editor/editor.jsx index 470220379..9b0a0d594 100644 --- a/client/homebrew/editor/editor.jsx +++ b/client/homebrew/editor/editor.jsx @@ -190,7 +190,8 @@ const Editor = createClass({ brewJump : function(targetPage=this.getCurrentPage()){ if(!window || this.isMeta()) return; // console.log(`Scroll to: p${targetPage}`); - const currentPos = window.frames['BrewRenderer'].contentDocument.getElementsByClassName('brewRenderer')[0].scrollTop; + const brewRenderer = window.frames['BrewRenderer'].contentDocument.getElementsByClassName('brewRenderer')[0]; + const currentPos = brewRenderer.scrollTop; const targetPos = window.frames['BrewRenderer'].contentDocument.getElementById(`p${targetPage}`).getBoundingClientRect().top; const interimPos = targetPos >= 0 ? -30 : 30; @@ -201,9 +202,9 @@ const Editor = createClass({ this.setState({ isBrewScrolling : true }); - window.frames['BrewRenderer'].contentDocument.getElementsByClassName('brewRenderer')[0].scrollTo({ top: currentPos + interimPos, behavior: 'smooth' }); + brewRenderer.scrollTo({ top: currentPos + interimPos, behavior: 'smooth' }); setTimeout(()=>{ - window.frames['BrewRenderer'].contentDocument.getElementsByClassName('brewRenderer')[0].scrollTo({ top: currentPos + targetPos, behavior: 'smooth', block: 'start' }); + brewRenderer.scrollTo({ top: currentPos + targetPos, behavior: 'smooth', block: 'start' }); }, bounceDelay); setTimeout(()=>{ this.setState({