f.weber/jekyll-theme-chirpy
Template
1
0
Fork 0
mirror of https://github.com/cotes2020/jekyll-theme-chirpy.git synced 2026-08-06 05:47:39 +00:00
Code Issues Packages Releases Activity

fix(dom): add missing datetime attribute on time element (#2759)

Browse Source 
The datetime attribute was missing from the time element, which is
recommended for semantic HTML. Add it using the date_to_xmlschema
Liquid filter to ensure proper ISO 8601 format.
This commit is contained in:
Yura
2026-06-29 01:16:49 +02:00
committed by GitHub
parent 6e12584926
commit 01c62bc636
2 changed files with 10 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
_javascript/modules/components/locale-datetime.js
+9 -24
View File
@@ -6,24 +6,14 @@
/* A tool for locale datetime */
class LocaleHelper {
static get attrTimestamp() {
return 'data-ts';
}
static get attrDateFormat() {
return 'data-df';
}
static datetimeAttr = 'datetime';
static get locale() {
return document.documentElement.getAttribute('lang').substring(0, 2);
}
static getTimestamp(elem) {
return Number(elem.getAttribute(this.attrTimestamp)); // unix timestamp
}
static getDateFormat(elem) {
return elem.getAttribute(this.attrDateFormat);
static getDatetime(elem) {
return elem.getAttribute(this.datetimeAttr);
}
}
@@ -32,22 +22,17 @@ export function initLocaleDatetime() {
dayjs.extend(window.dayjs_plugin_localizedFormat);
document
.querySelectorAll(`[${LocaleHelper.attrTimestamp}]`)
.querySelectorAll(`[${LocaleHelper.datetimeAttr}]`)
.forEach((elem) => {
const date = dayjs.unix(LocaleHelper.getTimestamp(elem));
const text = date.format(LocaleHelper.getDateFormat(elem));
elem.textContent = text;
elem.removeAttribute(LocaleHelper.attrTimestamp);
elem.removeAttribute(LocaleHelper.attrDateFormat);
const date = dayjs(LocaleHelper.getDatetime(elem));
elem.textContent = date.format(elem.dataset.df);
delete elem.dataset.df;
// setup tooltips
if (
elem.hasAttribute('data-bs-toggle') &&
elem.getAttribute('data-bs-toggle') === 'tooltip'
) {
if ('bsToggle' in elem.dataset && elem.dataset.bsToggle === 'tooltip') {
// see: https://day.js.org/docs/en/display/format#list-of-localized-formats
const tooltipText = date.format('llll');
elem.setAttribute('data-bs-title', tooltipText);
elem.dataset.bsTitle = tooltipText;
}
});
}