0
0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-05-09 16:18:39 +00:00
Commit Graph

15 Commits

Author SHA1 Message Date
Rae2che5 cbbb7292d9 Revert "Fix duplicated text from Class Feature snippet"
This reverts commit 9519a0b4e4.
2018-05-11 20:44:53 +01:00
Trevor Buckner 9519a0b4e4 Fix duplicated text from Class Feature snippet
When adding the Class Feature snippet, all curent text in the document is inserted in place of the randomly generated class name, creating several duplicates of the document and generally creating a mess.  See #413 which was closed but the issue was never fixed.

Most of the snippet code generators do not have any input arguments in the `module.exports` function, so they don't have this issue. However, Table of Contents needs to parse the text in the brew, so it is passed a copy of the brew document. Unfortunately, Class Feature (classfeature.gen.js) also has an input parameter for when it is used as part of the Full Class snippet.  Thus, the unintended consequence occurs in snippetbar.jsx in the `execute` function.

This fix simply adds a check to the execute function and only passes in the brew as an argument if the clicked snipped actually is the Table of Contents. Some restructuring might later reveal a cleaner way to do this rather than an awkward special case check like this.
2018-05-11 10:20:18 +01:00
Scott Tolksdorf f18a181e2e Updating to user create-react-class 2018-04-09 00:12:56 -04:00
Scott Tolksdorf ed1b5252be lint 2018-04-09 00:12:56 -04:00
Scott Tolksdorf 3247cab214 Fixing issue#413 class feature duping entire brew 2017-06-04 16:07:49 -04:00
Scott Tolksdorf 70346ffce7 Fixed saving authors and systems to brews 2017-01-19 12:06:14 -05:00
Scott Tolksdorf 9b936f42f3 Added tooltip to metadata editor and upped the version of font awesome 2017-01-14 14:35:36 -08:00
Scott Tolksdorf a35d684773 Changed icon and fixed 249 2016-12-25 23:09:22 -05:00
Scott Tolksdorf fe4a05dc25 Fixed the class table issue 2016-12-16 22:59:44 -05:00
Scott Tolksdorf 1f1bd669fe Added additional protection against debounce saving 2016-12-12 10:28:37 -05:00
Scott Tolksdorf be783e5f6b Added a table of contents snippet 2016-12-03 15:47:20 -05:00
Scott Tolksdorf bec417a325 Changed the meta editor icon 2016-12-03 14:02:28 -05:00
Scott Tolksdorf 8e6fccc969 Added account nav to newpage and added split table snippet 2016-12-01 10:06:23 -05:00
Scott Tolksdorf 4e5cd914f7 User page now running properly 2016-11-24 23:35:10 -05:00
Scott Tolksdorf e61bf22788 Added in metadata editor 2016-11-23 14:47:28 -05:00