Trevor Buckner
fbedafb204
typo
2025-01-05 23:04:57 -05:00
Trevor Buckner
85cd7c7336
Move calculation of error states outside of render
...
Our previous approach was technically bad practice to calculate side-effects inside of the render step. We can separate that out as part of this refactor.
Also use native javascript map instead of lodash.
2025-01-05 23:04:48 -05:00
Trevor Buckner
c137d40037
More alignment
2025-01-05 22:58:48 -05:00
Trevor Buckner
5a9e7850c2
space to tabs
2025-01-05 22:53:30 -05:00
Víctor Losada Hernández
49db31426c
Merge branch 'master' into refactor-errorBar-to-functional-and-using-dialog
2024-10-23 12:48:42 +02:00
Trevor Buckner
d5f498cbf9
Merge branch 'master' into scroll-to-element
2024-10-22 14:09:49 -04:00
Trevor Buckner
5040b9528f
cleanup
2024-10-22 14:08:20 -04:00
Trevor Buckner
83a48b8d0c
Simplify observer
2024-10-22 13:58:35 -04:00
Trevor Buckner
9fbdd24d01
Cleanup
2024-10-22 13:52:34 -04:00
Trevor Buckner
5b136f651c
Call scrollToHash from our existing "frameDidMount`
...
`frameDidMount` is equivalent to using iframe.addEventListener('load');
Let's not add a new listener and just use the existing event we already have. Functionality still works.
2024-10-22 13:03:12 -04:00
Víctor Losada Hernández
ebdbb39f24
linting
2024-10-20 22:29:14 +02:00
Víctor Losada Hernández
976740dc8b
make more concise
2024-10-20 22:21:07 +02:00
Víctor Losada Hernández
cac87b14c7
refactor to func comp and using dialog
2024-10-20 22:07:33 +02:00
Trevor Buckner
ac766f3b37
Update brewRenderer.jsx
2024-10-18 10:23:56 -04:00
Víctor Losada Hernández
189625c79b
adding margin to scroll action to prevent toolbar overlapping
2024-10-17 23:38:27 +02:00
Víctor Losada Hernández
d872a496a7
fix mutation observer integration
2024-10-17 23:38:11 +02:00
Víctor Losada Hernández
9a4473526a
move around 2
2024-10-17 22:59:29 +02:00
Víctor Losada Hernández
5077fda3f6
move stuff around for minimal changes
2024-10-17 22:58:14 +02:00
Víctor Losada Hernández
397ae31f56
remove stale changes
2024-10-17 22:56:58 +02:00
Víctor Losada Hernández
87915ef0ef
remove unnecessary changes
2024-10-17 22:42:55 +02:00
Víctor Losada Hernández
ccfd5578cf
Merge branch 'master' of https://github.com/naturalcrit/homebrewery into scroll-to-element
2024-10-17 22:39:28 +02:00
Trevor Buckner
7888bfa878
Merge branch 'master' into tweakBrewRendererBackgroundStyle
2024-10-16 16:23:47 -04:00
Trevor Buckner
2aa60f793d
Fix /new
...
/new starts with no `text` so it will crash without `?.`
2024-10-15 22:39:13 -04:00
Trevor Buckner
321bbba4b8
Rearrange
2024-10-15 22:07:41 -04:00
Trevor Buckner
36af1cdb7f
Update brewRenderer.jsx
2024-10-15 21:47:27 -04:00
Víctor Losada Hernández
3c66907a86
Merge branch 'master' of https://github.com/naturalcrit/homebrewery into scroll-to-element
2024-10-13 11:15:15 +02:00
Trevor Buckner
1c47d743d6
Remove 429 error
2024-10-11 23:20:32 -04:00
Trevor Buckner
52a7ce9866
Merge branch 'master' into v3.15.2
2024-10-11 23:08:41 -04:00
G.Ambatte
bec830c3b8
Tweak color of Brew Renderer background text
2024-10-12 08:09:51 +13:00
G.Ambatte
d534eddb29
Remove unnecessary useEffect import
2024-10-11 13:14:53 +13:00
G.Ambatte
9099db5ea1
Remove obsolete state and event handlers
2024-10-11 11:56:29 +13:00
G.Ambatte
a9a8b4b9bb
Shift static height style to LESS file
2024-10-11 11:55:51 +13:00
G.Ambatte
5d29d40c97
Implement suggested change
2024-10-11 11:42:03 +13:00
G.Ambatte
4291284252
Merge branch 'master' into experimentalDeploymentIdentification
2024-10-11 11:10:28 +13:00
Víctor Losada Hernández
6456c22c61
testing mutation Observer, don't review this yet
2024-10-09 21:33:26 +02:00
Víctor Losada Hernández
e396a51ad5
Merge branch 'v3.15.2' of https://github.com/naturalcrit/homebrewery into scroll-to-element
2024-10-07 11:47:13 +02:00
Trevor Buckner
1a325fb3c5
New notification
2024-10-01 22:25:17 -04:00
Trevor Buckner
ea656e5119
Issue notice
2024-09-29 00:15:26 -04:00
G.Ambatte
570c850c4f
Merge branch 'master' into fixToolbarZoomInPrint-#3744
2024-09-28 09:05:22 +12:00
G.Ambatte
17dfacd5c9
Add zoom property to BrewRenderer print styling
2024-09-28 09:03:00 +12:00
Trevor Buckner
ae123a8310
Change the other page number values as well
2024-09-27 11:35:01 -04:00
G.Ambatte
1f047890ab
Change default value of currentEditorCursorPageNum
2024-09-27 23:32:19 +12:00
Víctor Losada Hernández
2e5ebb861e
simplify logic
2024-09-17 19:50:39 +02:00
Víctor Losada Hernández
e92c169e71
Merge branch 'master' of https://github.com/naturalcrit/homebrewery into scroll-to-element
2024-09-16 23:01:40 +02:00
Trevor Buckner
63675a46e0
Lint more things
2024-09-16 01:42:21 -04:00
Trevor Buckner
5cc5eec619
Lint toolbar and snippetbar
2024-09-16 01:41:46 -04:00
Trevor Buckner
c07c02f1d9
Remove unused variable
2024-09-15 21:44:02 -04:00
Trevor Buckner
85401ba71b
Fix BrewRenderer scrolling to 0
2024-09-15 21:26:49 -04:00
Víctor Losada Hernández
e213eb0a78
"Refactor BrewRenderer: removed iframe load event listener, simplified page scrolling logic, and inlined getPageContainingElement functionality"
2024-09-15 18:37:27 +02:00
Víctor Losada Hernández
422829cbd8
Merge branch 'master' of https://github.com/naturalcrit/homebrewery into scroll-to-element
2024-09-15 16:52:12 +02:00