0
0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-05-08 14:18:40 +00:00
Commit Graph

405 Commits

Author SHA1 Message Date
Gazook89 2a8eaa654d updated package-lock 2023-03-07 21:55:49 -06:00
Gazook89 29f8f3546c Merge branch 'master' into Language-Attribute 2023-03-07 21:23:23 -06:00
Trevor Buckner bfccf833b6 Fix variable name conflict bugs 2023-03-07 14:27:33 -05:00
Michiel De Mey 2a9ac9fa47 Defining default auth at the top 2023-03-07 11:05:11 +01:00
Michiel De Mey a6ed05214a Updated auth 2023-02-26 14:53:26 +01:00
Michiel De Mey 27ea00e9ce Trimming Google APIs 2023-02-26 14:34:23 +01:00
Trevor Buckner 6a8a2f080c Lint 2023-02-18 13:48:32 -05:00
Trevor Buckner 298a10bc42 Clean up tests 2023-02-18 13:48:02 -05:00
G.Ambatte 1fb7fe2487 Add markModified mock function to test spec 2023-02-17 17:43:21 +13:00
G.Ambatte e751f9a25c Remove mocking function from homebrew.api.js 2023-02-17 17:42:56 +13:00
G.Ambatte 41db670e63 Add mock markModified when it does not exist 2023-02-17 16:14:33 +13:00
G.Ambatte 4b98c1ac89 Add markModified to fix authors array in DB 2023-02-17 11:26:11 +13:00
G.Ambatte 4a695eda87 Fix outdated method in Admin API 2023-02-03 19:28:20 +13:00
Trevor Buckner 4260f5197c Update specs to expect a views prop from default brew 2023-01-30 17:15:33 -05:00
Trevor Buckner f628e1a5ae Use DEFAULT_BREW values instead of setting them here 2023-01-30 17:08:19 -05:00
Victor Losada Hernandez 541109e7b1 fix created, updated published last viewed 2023-01-28 11:47:26 +01:00
Charlie Humphreys 4ae751bf70 Merge branch 'master' into content-negotiation-middleware 2023-01-25 23:01:31 -06:00
Charlie Humphreys b77c70054a adjust content-negotiation middleware to elvis on the accept header 2023-01-25 23:00:05 -06:00
Trevor Buckner 0a9a5909d1 Merge pull request #2589 from jeddai/client-server-version-mismatch-middleware
adjust frontend error handling, add client/server mismatch middleware
2023-01-23 15:40:48 -05:00
Victor Losada Hernandez 0f88a13635 Merge branch 'master' of hb into Cloning-views-fix 2023-01-22 22:11:23 +01:00
Victor Losada Hernandez e8c7d38608 setting view count to 0 2023-01-22 21:57:14 +01:00
Trevor Buckner 6020657529 Ensure getBrew returns an object if undefined 2023-01-22 21:57:14 +01:00
Trevor Buckner a8c35f3967 Remove extra console log for getGoogleBrew
App.js already logs the thrown error, so we were getting double logs (and Google errors are long....). This should make the logs a bit easier to sift through.
2023-01-22 21:57:13 +01:00
Trevor Buckner 62fa8f511a Only fix stub if we actually found one. 2023-01-22 21:57:13 +01:00
Trevor Buckner 18cf202ac0 If no stub exists, start stub as {}, not undefined
Recent changes to handle bad brew properties (tags as strings, no renderer, etc.) didn't account for the case where an old Google brew is first being stubbed; since no stub exists, there is no object to perform the corrections on, and we crash.
2023-01-22 21:57:13 +01:00
Trevor Buckner 98d9018e13 Fix saving issue when tags do not exist
Rare case where tags don't exist at all; gets confused in the step of converting tag strings to arrays
2023-01-22 21:57:13 +01:00
Trevor Buckner a9e14f6165 Enable brew version mismatch checking on server
Was commented out previously to allow users time to update client code so the proper error displays
2023-01-22 21:57:13 +01:00
Charlie Humphreys 8b0203dd7c add content negotiation middleware and tests 2023-01-21 00:48:41 -06:00
Charlie Humphreys 6bae21a578 Merge branch 'master' into client-server-version-mismatch-middleware 2023-01-21 00:26:18 -06:00
Charlie Humphreys 7755affa1e update based on feedback 2023-01-20 23:07:24 -06:00
Trevor Buckner c9241e2162 Fix Google Drive brews duplicating 2023-01-20 17:19:02 -05:00
Trevor Buckner da676c6ec1 Ensure getBrew returns an object if undefined 2023-01-12 13:33:55 -05:00
Trevor Buckner 901615d99e Remove extra console log for getGoogleBrew
App.js already logs the thrown error, so we were getting double logs (and Google errors are long....). This should make the logs a bit easier to sift through.
2023-01-10 21:08:21 -05:00
Trevor Buckner 6ed52f37cc Only fix stub if we actually found one. 2023-01-09 17:30:49 -05:00
Trevor Buckner 15e5a31767 If no stub exists, start stub as {}, not undefined
Recent changes to handle bad brew properties (tags as strings, no renderer, etc.) didn't account for the case where an old Google brew is first being stubbed; since no stub exists, there is no object to perform the corrections on, and we crash.
2023-01-09 14:53:35 -05:00
Trevor Buckner 8cbab4d4ce Fix saving issue when tags do not exist
Rare case where tags don't exist at all; gets confused in the step of converting tag strings to arrays
2023-01-09 14:12:57 -05:00
Trevor Buckner a9c28e84d0 Enable brew version mismatch checking on server
Was commented out previously to allow users time to update client code so the proper error displays
2023-01-09 10:30:07 -05:00
Charlie Humphreys 385bee964d adjust frontend error handling, add client/server mismatch middleware 2023-01-06 21:29:21 -06:00
Charlie Humphreys a54ebabf53 fix tests after merge from master 2023-01-05 23:10:25 -06:00
Charlie Humphreys 676acb9e5a Merge branch 'master' into api-tests 2023-01-05 23:02:43 -06:00
Charlie Humphreys 387c468d84 add tests for deletion and address PR feedback 2023-01-05 22:56:54 -06:00
Trevor Buckner c78d687387 Fix all brews being forced to V3 on load 2023-01-04 21:32:16 -05:00
Trevor Buckner b717059a39 Fix /new storing string "undefined" in Style tab 2023-01-04 20:58:29 -05:00
Trevor Buckner e02bde5eed Cleanup; added more fields to DEFAULT_BREW 2023-01-04 17:33:23 -05:00
Trevor Buckner 6dab5f836e Merge branch 'master' into pr/2429 2023-01-03 15:13:19 -05:00
Charlie Humphreys e47f81698c Merge branch 'master' into api-tests 2023-01-03 13:47:09 -06:00
Trevor Buckner 6eaf2feb40 Log version mismatch errors
To gauge how frequently they are occurring for future update.
2023-01-03 12:47:17 -05:00
Trevor Buckner 4fe0f1a7af Comment out server-side brew version checking
Requires client-side update to apply brew version correctly; temporarily disabling server-side checking for a few days until more users have updated their clients.
2023-01-03 12:38:00 -05:00
Charlie Humphreys ca03a473ec add check for truthy version, and make sure the version exists when incrementing it 2022-12-23 14:31:58 -06:00
Charlie Humphreys da9e20e96f add more tests and merge from main 2022-12-23 00:11:46 -06:00