Commit Graph
3101 Commits
Author SHA1 Message Date
Víctor Losada Hernández 921293d39f Merge branch 'master' of https://github.com/naturalcrit/homebrewery into Accessible-Dropdowns 2026-08-16 10:41:40 +02:00
Víctor Losada Hernández 3442c877f8 final touches to snippetbar breakpoints 2026-08-16 10:41:27 +02:00
Gazook89 eddc1421b2 Merge branch 'master' into Accessible-Dropdowns 2026-08-15 12:05:00 -05:00
Gazook89 480c5c3eb6 update div to button.
conflict resolution with #4932-- preserves the intention of that PR, but with new structure of this PR.
2026-08-15 10:36:15 -05:00
Gazook89 1cf338b3e1 Merge branch 'master' into Nav.jsx-To-Functional-Component 2026-08-15 10:21:52 -05:00
durstann 5ddc0373b7 Fix a11y issues on the brew item card so screen reader users and keyboard navigators can use it. 2026-08-05 15:28:27 -07:00
Víctor Losada Hernández d15daa7ad2 Merge branch 'master' into labels 2026-08-04 16:04:07 +02:00
G.Ambatte c1ad9209a0 Merge branch 'master' into fixSafeHTML 2026-08-01 16:53:50 +12:00
Víctor Losada Hernández 98d579fc8a Merge branch 'master' into Accessible-Dropdowns 2026-07-29 18:38:57 +02:00
durstann 2febc01ff4 add aria labels to toolbar elements 2026-07-28 01:26:00 -07:00
Gazook89 caeeabc735 fixes to colors, and editor wrapping breakpoint. 2026-07-27 21:47:58 -05:00
durstann 3628d1d57d Add nav buttons to the tab order and use semantic buttons so they are interactable with the keyboard 2026-07-26 23:47:10 -07:00
G.Ambatte 341b3c24a4 Merge branch 'master' into fixSafeHTML 2026-07-26 11:08:44 +12:00
Víctor Losada Hernández 16ec16c6b8 small changes 2026-07-26 01:05:13 +02:00
Víctor Losada Hernández 2a6e77731b Merge branch 'master' of https://github.com/naturalcrit/homebrewery into add-remove-author-if-owner 2026-07-26 00:22:32 +02:00
G.Ambatte cd8df1c4b3 Merge branch 'master' into sandbox-renderer-iframe 2026-07-26 09:48:31 +12:00
Víctor Losada Hernández 71c13a89a8 Merge branch 'master' into render_a11y_squash 2026-07-25 23:44:49 +02:00
durstann 7d434fe939 Revert linter change 2026-07-23 18:57:01 -07:00
ReinaSweet 5fa7b95e19 Add a sandbox property to the renderer iframe to prevent any script execution
But still allow for print (via allow-modals), same-origin downloads, and top navigation (so that links work).
2026-07-18 03:02:41 -07:00
G.Ambatte e078f1f6fa Change safeHTML attribute check 2026-07-15 21:25:28 +12:00
Gazook89 4e5e5986cd refactor nav.jsx into functional component
Mostly a straightforward change to a functional component.  Smaller refactors include removing `_.omit` which isn't needed.
2026-07-13 22:41:42 -05:00
Gazook89 fd6fd98fdc Add @components aliases to vite config
And update all the files to point to that directory to use the alias.
2026-07-11 17:41:49 -05:00
Gazook89 fe297a47b2 cleanup extra css
Remove some unused css rules that weren't cut before, and a little bit of rearranging to group "dropdown" stuff together and "tools" together.
2026-07-09 14:14:21 -05:00
Gazook89 5d67d48436 Add custom properties to dropdown.less
Adds registered custom properties to the dropdown menus, which can be set in another stylesheet at any level (either on the direct element or on an ancestor) or use the default values given.
2026-07-09 14:13:22 -05:00
Gazook89 794c2fa09d add disabled attribute to items. beta to status
Adds the `disabled` attribute to a menu-item button if it's disabled, not just as a className.  Styling changes centered on that as well.

Also changes the `beta` class to `status` because it is used for both `beta` and `disabled` indicators.  Styling changes for that.
2026-07-09 14:10:49 -05:00
Gazook89 6f1ad35492 add aria labels to items 2026-07-08 23:35:45 -05:00
Gazook89 8e720d1c60 Set html structure to ul/li. Set roles.
The snippets are a `menubar` in terms of role, and is a list of items (`menitem`, `li`).

Note for myself:  submenus are `menu` roles that immediately follow their triggering `menuitem` and are direct children of the parent `menu`, per WCAG.  This is done in this commit.
2026-07-08 22:06:00 -05:00
Gazook89 f67ab5bb16 update brewRenderer.jsx 2026-07-04 20:25:01 -05:00
Gazook89 9048253c9c revert some unintended changes from an earlier merge
commit e02ce4f898 unintentionally undid some changes for v4 by dbolack, I'm not really sure how.  It's evidently not possible to directly "revert" those changes without having a conflicted file, i think something was borked in the process.

manually reverting the changes here, hopefully it works out.
2026-07-04 20:16:02 -05:00
Gazook89 416161e617 fix to previous commit. 2026-07-02 23:44:19 -05:00
Gazook89 3836150e42 hide arrows on snippetbar triggers, improve spacing
to decrease the width used for the snippet bar triggers, removed the down arrows (for the top level triggers only).  And, reduced the padding on the icons in the snippetbar while retaining it inside the menus.

The icons still align between the menu list and the menu trigger, but the text labels do not.
2026-07-02 23:40:01 -05:00
durstann 8c77da246c Don't add lang tag to iframe content. It's not strictly necessary since the brew content will set it's own language later in the DOM. 2026-06-19 14:38:49 -07:00
durstann 487d7956e9 Accessibility: Add lang and title to the brew render iframe. 2026-06-18 12:58:11 -07:00
Gazook89 1861d036b9 add key to dropdown menuitem 2026-06-09 06:25:31 -05:00
David Bolack 36ae3734fb Merge branch 'master' into V4_Persistant_Templates
Change enable_v4 to enableV4 to shut up linter.
2026-05-29 21:06:55 -05:00
Gazook89 c12a188196 Be sure snippet icon is getting passed in 2026-05-28 11:45:14 -05:00
Gazook89 5e122626d4 Merge branch 'master' into Better-Dropdowns 2026-05-27 22:22:34 -05:00
Gazook89 612614fa12 menu items dismiss menu on click by default
Unless a menu item has the `no-dismiss` attribute (set to either `''` or `'true'`), clicking a menu item will dismiss the menu.  Clicking a submenu trigger will not dismiss the menu.

The `no-dismiss` attribute must take a string, either empty or `'true'` because react doesn't allow boolean custom attributes.
2026-05-27 22:21:28 -05:00
Víctor Losada Hernández 305a668799 Merge branch 'master' into Open-Sans---Installed-vs-Google-Fonts 2026-05-22 22:48:16 +02:00
Gazook89 029d2c9f33 Merge branch 'master' into Lazy-Load-Images 2026-05-22 15:04:17 -05:00
David Bolack dff93002d0 Clarify Regex behavior
Add short circuit so the full hoisting only happens on brew load rather than every parse.
Remove stray CR in unrelated file.
2026-05-18 21:59:56 -05:00
David Bolack 84fbf75f0c Merge branch 'master' into preloadVars 2026-05-18 21:50:32 -05:00
Víctor Losada Hernández 15db3c9f66 lint client 2026-05-18 16:21:57 +02:00
Gazook89 f5acb27c34 Revert "Fix font snippet "Open Sans""
This reverts commit 34d634a349.
2026-05-05 22:38:43 -05:00
Trevor Buckner b75c83901b Merge branch 'fix-save-on-load' of https://github.com/5e-Cleric/homebrewery into pr/4772 2026-05-04 16:01:43 -04:00
Trevor Buckner 339d2844a7 Change logic to fire on button click, rather than on state change
Ideally side effects (server calls, etc.) should happen outside of useEffect anyway for reasons like this; Putting the save in the button click keeps the logic in one place instead of spread across multiple functions and renders,

(This change was already made in my local copy toward combining Edit/New/Home pages.)
2026-05-04 16:01:39 -04:00
Trevor Buckner 614d9fd7b3 Merge branch 'master' into fix-save-on-load 2026-05-04 11:50:13 -04:00
Víctor Losada Hernández 65d1106974 this should fix it 2026-05-04 00:42:10 +02:00
Gazook89 34d634a349 Fix font snippet "Open Sans"
Previously it was using 'OpenSans' as the font name, when it's actually 'Open Sans'.
2026-05-01 15:17:30 -05:00
Gazook89 e34c5f9b32 Add font files, remove google fonts references
Adds a `shared/naturalcrit/styles/fonts` directory, and Open Sans font files for the 4 weights we were pulling from Google Fonts.
2026-04-30 22:28:04 -05:00