0
0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2025-12-25 14:02:40 +00:00
Commit Graph

2692 Commits

Author SHA1 Message Date
David Bolack
4db4bba73f Merge branch 'master' into issue_3974 2025-01-10 11:19:13 -06:00
David Bolack
1aeea034d2 Requested corrections? 2025-01-09 22:34:35 -06:00
G.Ambatte
19cb24d8db Add explanatory comments to HeaderNav.jsx 2025-01-10 16:48:02 +13:00
David Bolack
96ebe0f617 Apply fix to clear error. 2025-01-09 16:42:55 -06:00
G.Ambatte
eb3178bf80 Update nav item selector 2025-01-09 14:17:41 +13:00
G.Ambatte
a72f47df46 Add identifier to ToC pages in header nav 2025-01-09 12:53:52 +13:00
G.Ambatte
a9823d39e2 Update selection query 2025-01-09 12:29:18 +13:00
G.Ambatte
6ec65eee23 Skip Table of Contents pages 2025-01-09 08:13:59 +13:00
G.Ambatte
9c2610ff40 Add guard clause to prevent empty nav lines 2025-01-09 08:07:59 +13:00
Trevor Buckner
914521cada Merge branch 'master' into experimentalHeaderNavigation 2025-01-07 22:49:05 -05:00
Trevor Buckner
70bda94033 Lint Toolbar.jsx 2025-01-07 22:47:18 -05:00
Trevor Buckner
915137af5e Lint BrewRenderer.jsx 2025-01-07 22:47:04 -05:00
Trevor Buckner
fdfae9a771 Merge branch 'master' into experimentalHeaderNavigation 2025-01-07 22:43:29 -05:00
Trevor Buckner
8cc693461d Lint EditPage.jsx 2025-01-07 22:43:06 -05:00
G.Ambatte
bffa6eb0c9 Limit max-height to prevent overflow
Co-authored-by: Víctor Losada Hernández <5ecleric.naturalcrit@gmail.com>
2025-01-08 07:22:17 +13:00
G.Ambatte
2779055e50 Stop error bar from blocking menus 2025-01-07 18:02:17 +13:00
G.Ambatte
37d00f1255 Remove dismissKeys check before displaying dialog 2025-01-07 18:01:58 +13:00
G.Ambatte
d9b599e814 Fix error listing 2025-01-07 18:01:17 +13:00
G.Ambatte
40d453bc7c Return if no notifications 2025-01-07 18:00:45 +13:00
Trevor Buckner
6ff0cfe383 Merge branch 'master' into refactor-errorBar-to-functional-and-using-dialog 2025-01-06 12:03:34 -05:00
G.Ambatte
a6b7ed4dd2 Improve link text generation 2025-01-06 23:54:05 +13:00
G.Ambatte
bf0614026d Use classes rather than inline styling for indentation 2025-01-06 23:53:33 +13:00
G.Ambatte
06005009e4 HeaderList now in nav > ul > li 2025-01-06 23:20:52 +13:00
G.Ambatte
cf16566da8 Move Header Navigation button to Toolbar 2025-01-06 22:30:03 +13:00
G.Ambatte
34f104b406 Remove showHeaderNav prop from Edit and Share page BrewRenderer 2025-01-06 22:29:22 +13:00
Trevor Buckner
766ab8f10a Lint 2025-01-05 23:07:53 -05:00
Trevor Buckner
aa4276a50e Move exit condition to start 2025-01-05 23:06:56 -05:00
Trevor Buckner
fbedafb204 typo 2025-01-05 23:04:57 -05:00
Trevor Buckner
85cd7c7336 Move calculation of error states outside of render
Our previous approach was technically bad practice to calculate side-effects inside of the render step. We can separate that out as part of this refactor.

Also use native javascript map instead of lodash.
2025-01-05 23:04:48 -05:00
Trevor Buckner
c137d40037 More alignment 2025-01-05 22:58:48 -05:00
Trevor Buckner
5a9e7850c2 space to tabs 2025-01-05 22:53:30 -05:00
G.Ambatte
a95eef0545 Add maximum length, use span for spacing 2025-01-03 13:34:52 +13:00
G.Ambatte
bbf6c3589a Switch from innerText to textContent 2025-01-03 11:53:29 +13:00
G.Ambatte
4a4a14b2ab Add ref correctly, fix typo 2025-01-03 11:37:51 +13:00
G.Ambatte
6b0c3b65b4 Merge branch 'master' into experimentalHeaderNavigation 2025-01-03 11:20:16 +13:00
Trevor Buckner
d84f071c62 Other small cleanup 2024-12-26 19:20:25 -05:00
Trevor Buckner
bc7297de2e Mirror editId logic from shareId 2024-12-26 19:15:33 -05:00
Trevor Buckner
a2c4f73e7d processShareId does not need useCallback() 2024-12-26 19:12:34 -05:00
Trevor Buckner
9804c3933f Remove unneeded dependencies for useEffect
UseEffect is only intended to be called once.

Similarly, handleControlKeys doesn't need "useCallBack" because it will never be passed to a child or trigger any re-render by changing.
2024-12-26 19:09:23 -05:00
Trevor Buckner
e2b0da7830 Merge branch 'master' into refactor-share-page-as-functional-comp 2024-12-26 18:50:48 -05:00
Víctor Losada Hernández
c310a8c1c2 Merge branch 'master' into refactor-brewItem-component 2024-12-26 21:07:44 +01:00
Trevor Buckner
1c0eb720ad Undo 2024-12-24 00:38:36 -05:00
Trevor Buckner
93482f9022 Only list one page when in single page mode 2024-12-24 00:37:03 -05:00
Trevor Buckner
8159c408c8 Move formatVisiblePages
After simplifying, this has become a single-line function used in only one place. Can just be placed directly in the one place it is used.
2024-12-24 00:24:52 -05:00
Trevor Buckner
0632d78f71 Remove toolbar checks for empty visiblePages list
With `centerPage`, ToolBar will never receive an empty visiblePages array. No need to check if visiblepages.length == 0
2024-12-24 00:18:37 -05:00
Trevor Buckner
c0155052ea Further simplifying 2024-12-24 00:06:30 -05:00
Trevor Buckner
628b2542a0 Simplify logic for previous/next buttons 2024-12-24 00:02:55 -05:00
Trevor Buckner
85f1da942f Restore looping over entries. Needed for very fast scrolling 2024-12-23 23:08:30 -05:00
Trevor Buckner
3909d5aef9 remove unused iFrameRef
iFrameRef is not used anywhere
2024-12-23 22:48:57 -05:00
Trevor Buckner
f0e047e7cc Remove loop on intersectionObserver entries
Guaranteed to only be one entry each time, since we are attaching each page to its own observers.
2024-12-23 22:43:37 -05:00