0
0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-05-09 22:48:39 +00:00
Commit Graph

623 Commits

Author SHA1 Message Date
G.Ambatte 6ec65eee23 Skip Table of Contents pages 2025-01-09 08:13:59 +13:00
G.Ambatte 9c2610ff40 Add guard clause to prevent empty nav lines 2025-01-09 08:07:59 +13:00
Trevor Buckner 914521cada Merge branch 'master' into experimentalHeaderNavigation 2025-01-07 22:49:05 -05:00
Trevor Buckner 70bda94033 Lint Toolbar.jsx 2025-01-07 22:47:18 -05:00
Trevor Buckner 915137af5e Lint BrewRenderer.jsx 2025-01-07 22:47:04 -05:00
Trevor Buckner fdfae9a771 Merge branch 'master' into experimentalHeaderNavigation 2025-01-07 22:43:29 -05:00
G.Ambatte bffa6eb0c9 Limit max-height to prevent overflow
Co-authored-by: Víctor Losada Hernández <5ecleric.naturalcrit@gmail.com>
2025-01-08 07:22:17 +13:00
G.Ambatte 2779055e50 Stop error bar from blocking menus 2025-01-07 18:02:17 +13:00
G.Ambatte d9b599e814 Fix error listing 2025-01-07 18:01:17 +13:00
G.Ambatte 40d453bc7c Return if no notifications 2025-01-07 18:00:45 +13:00
Trevor Buckner 6ff0cfe383 Merge branch 'master' into refactor-errorBar-to-functional-and-using-dialog 2025-01-06 12:03:34 -05:00
G.Ambatte a6b7ed4dd2 Improve link text generation 2025-01-06 23:54:05 +13:00
G.Ambatte bf0614026d Use classes rather than inline styling for indentation 2025-01-06 23:53:33 +13:00
G.Ambatte 06005009e4 HeaderList now in nav > ul > li 2025-01-06 23:20:52 +13:00
G.Ambatte cf16566da8 Move Header Navigation button to Toolbar 2025-01-06 22:30:03 +13:00
Trevor Buckner 766ab8f10a Lint 2025-01-05 23:07:53 -05:00
Trevor Buckner aa4276a50e Move exit condition to start 2025-01-05 23:06:56 -05:00
Trevor Buckner fbedafb204 typo 2025-01-05 23:04:57 -05:00
Trevor Buckner 85cd7c7336 Move calculation of error states outside of render
Our previous approach was technically bad practice to calculate side-effects inside of the render step. We can separate that out as part of this refactor.

Also use native javascript map instead of lodash.
2025-01-05 23:04:48 -05:00
Trevor Buckner c137d40037 More alignment 2025-01-05 22:58:48 -05:00
Trevor Buckner 5a9e7850c2 space to tabs 2025-01-05 22:53:30 -05:00
G.Ambatte a95eef0545 Add maximum length, use span for spacing 2025-01-03 13:34:52 +13:00
G.Ambatte bbf6c3589a Switch from innerText to textContent 2025-01-03 11:53:29 +13:00
G.Ambatte 4a4a14b2ab Add ref correctly, fix typo 2025-01-03 11:37:51 +13:00
G.Ambatte 6b0c3b65b4 Merge branch 'master' into experimentalHeaderNavigation 2025-01-03 11:20:16 +13:00
Trevor Buckner 1c0eb720ad Undo 2024-12-24 00:38:36 -05:00
Trevor Buckner 93482f9022 Only list one page when in single page mode 2024-12-24 00:37:03 -05:00
Trevor Buckner 8159c408c8 Move formatVisiblePages
After simplifying, this has become a single-line function used in only one place. Can just be placed directly in the one place it is used.
2024-12-24 00:24:52 -05:00
Trevor Buckner 0632d78f71 Remove toolbar checks for empty visiblePages list
With `centerPage`, ToolBar will never receive an empty visiblePages array. No need to check if visiblepages.length == 0
2024-12-24 00:18:37 -05:00
Trevor Buckner c0155052ea Further simplifying 2024-12-24 00:06:30 -05:00
Trevor Buckner 628b2542a0 Simplify logic for previous/next buttons 2024-12-24 00:02:55 -05:00
Trevor Buckner 85f1da942f Restore looping over entries. Needed for very fast scrolling 2024-12-23 23:08:30 -05:00
Trevor Buckner 3909d5aef9 remove unused iFrameRef
iFrameRef is not used anywhere
2024-12-23 22:48:57 -05:00
Trevor Buckner f0e047e7cc Remove loop on intersectionObserver entries
Guaranteed to only be one entry each time, since we are attaching each page to its own observers.
2024-12-23 22:43:37 -05:00
Trevor Buckner d588a92147 Change page range to only display a single range
Having multiple page ranges visible is a weird edge case that only happens in two-page view. Simplifying logic to just group all page ranges together if a middle page is partly obscured.
2024-12-23 18:37:20 -05:00
Trevor Buckner 2b7a1e1cb2 Reduce overlapping observer handlers
Combine handlePageVisibilityChange and handleCenterPageChange to reduce some of the infrastructure burden for handling centerPage.
2024-12-23 18:35:36 -05:00
Trevor Buckner c8efca3120 useCallBack is not needed here. 2024-12-23 17:22:50 -05:00
Trevor Buckner a53eacf055 remove CenterPage from ToolBar props
centerPage is not used in the toolbar component.
2024-12-23 17:17:13 -05:00
Trevor Buckner 1b10a4001a Merge branch 'master' into pr/3845 2024-12-23 11:37:40 -05:00
Trevor Buckner 870a4c3363 small cleanups 2024-12-09 17:06:26 -05:00
Trevor Buckner aa951ff96c Small cleanups 2024-12-09 17:04:16 -05:00
Trevor Buckner bae9fe939d Merge branch 'master' into Intersection-Observer 2024-12-09 16:16:11 -05:00
Víctor Losada Hernández 2c5c3d40df revert toolbar changes 2024-12-09 22:08:39 +01:00
Víctor Losada Hernández eca0f59b40 Merge branch 'master' of https://github.com/naturalcrit/homebrewery into adress-small-accessibility-concerns 2024-12-09 21:52:25 +01:00
David Bolack e252a39bd2 Implement Gazook89's suggested fix 2024-12-01 11:41:29 -06:00
Trevor Buckner fb9148ada5 Site runs and all tests pass 2024-11-20 16:21:35 -05:00
Víctor Losada Hernández cf46a975aa Merge branch 'master' into Update-core-and-reset 2024-11-12 22:05:27 +01:00
David Bolack 4e4463fe4d Fix Issue 3718 by bounds checking prerender. 2024-11-11 11:17:00 -06:00
Gazook89 9bc4b1fb56 Changes to core.less, reset.less, and toolbar
Making some changes to the reset.less so that some default UA button styling is removed.

Then, changing core.less so that the classic "HB" button styling is scoped to a certain class `.colorButton`.  This will make it easier to use the button element in other places.
2024-11-10 21:48:01 -06:00
Gazook89 28a7f24989 add scrollToHash method back in
pretty much completely unchanged, was originally moved just to help with merging master in (ie it was erroneously removed)
2024-11-07 20:32:30 -06:00