Trevor Buckner
8cc693461d
Lint EditPage.jsx
2025-01-07 22:43:06 -05:00
G.Ambatte
2779055e50
Stop error bar from blocking menus
2025-01-07 18:02:17 +13:00
G.Ambatte
37d00f1255
Remove dismissKeys check before displaying dialog
2025-01-07 18:01:58 +13:00
G.Ambatte
d9b599e814
Fix error listing
2025-01-07 18:01:17 +13:00
G.Ambatte
40d453bc7c
Return if no notifications
2025-01-07 18:00:45 +13:00
Trevor Buckner
6ff0cfe383
Merge branch 'master' into refactor-errorBar-to-functional-and-using-dialog
2025-01-06 12:03:34 -05:00
Trevor Buckner
766ab8f10a
Lint
2025-01-05 23:07:53 -05:00
Trevor Buckner
aa4276a50e
Move exit condition to start
2025-01-05 23:06:56 -05:00
Trevor Buckner
fbedafb204
typo
2025-01-05 23:04:57 -05:00
Trevor Buckner
85cd7c7336
Move calculation of error states outside of render
...
Our previous approach was technically bad practice to calculate side-effects inside of the render step. We can separate that out as part of this refactor.
Also use native javascript map instead of lodash.
2025-01-05 23:04:48 -05:00
Trevor Buckner
c137d40037
More alignment
2025-01-05 22:58:48 -05:00
Trevor Buckner
5a9e7850c2
space to tabs
2025-01-05 22:53:30 -05:00
Trevor Buckner
d84f071c62
Other small cleanup
2024-12-26 19:20:25 -05:00
Trevor Buckner
bc7297de2e
Mirror editId logic from shareId
2024-12-26 19:15:33 -05:00
Trevor Buckner
a2c4f73e7d
processShareId does not need useCallback()
2024-12-26 19:12:34 -05:00
Trevor Buckner
9804c3933f
Remove unneeded dependencies for useEffect
...
UseEffect is only intended to be called once.
Similarly, handleControlKeys doesn't need "useCallBack" because it will never be passed to a child or trigger any re-render by changing.
2024-12-26 19:09:23 -05:00
Trevor Buckner
e2b0da7830
Merge branch 'master' into refactor-share-page-as-functional-comp
2024-12-26 18:50:48 -05:00
Víctor Losada Hernández
c310a8c1c2
Merge branch 'master' into refactor-brewItem-component
2024-12-26 21:07:44 +01:00
Trevor Buckner
1c0eb720ad
Undo
2024-12-24 00:38:36 -05:00
Trevor Buckner
93482f9022
Only list one page when in single page mode
2024-12-24 00:37:03 -05:00
Trevor Buckner
8159c408c8
Move formatVisiblePages
...
After simplifying, this has become a single-line function used in only one place. Can just be placed directly in the one place it is used.
2024-12-24 00:24:52 -05:00
Trevor Buckner
0632d78f71
Remove toolbar checks for empty visiblePages list
...
With `centerPage`, ToolBar will never receive an empty visiblePages array. No need to check if visiblepages.length == 0
2024-12-24 00:18:37 -05:00
Trevor Buckner
c0155052ea
Further simplifying
2024-12-24 00:06:30 -05:00
Trevor Buckner
628b2542a0
Simplify logic for previous/next buttons
2024-12-24 00:02:55 -05:00
Trevor Buckner
85f1da942f
Restore looping over entries. Needed for very fast scrolling
2024-12-23 23:08:30 -05:00
Trevor Buckner
3909d5aef9
remove unused iFrameRef
...
iFrameRef is not used anywhere
2024-12-23 22:48:57 -05:00
Trevor Buckner
f0e047e7cc
Remove loop on intersectionObserver entries
...
Guaranteed to only be one entry each time, since we are attaching each page to its own observers.
2024-12-23 22:43:37 -05:00
Trevor Buckner
d588a92147
Change page range to only display a single range
...
Having multiple page ranges visible is a weird edge case that only happens in two-page view. Simplifying logic to just group all page ranges together if a middle page is partly obscured.
2024-12-23 18:37:20 -05:00
Trevor Buckner
2b7a1e1cb2
Reduce overlapping observer handlers
...
Combine handlePageVisibilityChange and handleCenterPageChange to reduce some of the infrastructure burden for handling centerPage.
2024-12-23 18:35:36 -05:00
Trevor Buckner
c8efca3120
useCallBack is not needed here.
2024-12-23 17:22:50 -05:00
Trevor Buckner
a53eacf055
remove CenterPage from ToolBar props
...
centerPage is not used in the toolbar component.
2024-12-23 17:17:13 -05:00
Trevor Buckner
1b10a4001a
Merge branch 'master' into pr/3845
2024-12-23 11:37:40 -05:00
Trevor Buckner
3f87b9f7d3
Merge branch 'master' into addGoogleRefreshInfoToErrorPage-#3955
2024-12-22 22:30:04 -05:00
Trevor Buckner
32561cf368
Moving to just HBErrorCode 01
...
02 is specifically for 404 errors when the file is actually missing. In that case, refreshing credentials probably won't work. (We should update the errorNav to make this distinction as well.)
2024-12-22 22:19:02 -05:00
Trevor Buckner
e8eedcf6d6
Import polyfill from core-js
...
Possible to have babel automatically detect and import polyfills as needed, but Browserify just can't handle it. Manually importing the one troublesome one into the root of our project.
2024-12-22 21:32:30 -05:00
G.Ambatte
fcfd3171bd
Tweak start of instructions
2024-12-22 18:00:27 +13:00
G.Ambatte
9a6cf8c5d2
Linter fix
2024-12-22 17:53:14 +13:00
G.Ambatte
91d928fd8a
End list properly
2024-12-22 17:52:58 +13:00
G.Ambatte
bca653bc4d
Add instructions to HBErrorCode 01 & 02
2024-12-22 17:52:09 +13:00
Trevor Buckner
962a46a670
Merge branch 'master' into fix-reddit-link-generation-crashing-website-if-encodeURI-fails
2024-12-15 23:46:54 -05:00
Trevor Buckner
cb16b32016
tabs
2024-12-15 23:45:54 -05:00
Trevor Buckner
56f348f7ed
Replace with toWellFormed()
2024-12-15 23:44:56 -05:00
Trevor Buckner
db0df82202
Change imports
2024-12-14 21:31:49 -05:00
Trevor Buckner
870a4c3363
small cleanups
2024-12-09 17:06:26 -05:00
Trevor Buckner
aa951ff96c
Small cleanups
2024-12-09 17:04:16 -05:00
Víctor Losada Hernández
3a20452214
hide unusable editors
2024-12-09 22:18:15 +01:00
Trevor Buckner
bae9fe939d
Merge branch 'master' into Intersection-Observer
2024-12-09 16:16:11 -05:00
Víctor Losada Hernández
3e4ba89ed9
change div selector
2024-12-09 22:11:10 +01:00
Víctor Losada Hernández
2c5c3d40df
revert toolbar changes
2024-12-09 22:08:39 +01:00
Víctor Losada Hernández
213240327d
resolve issues
2024-12-09 22:05:04 +01:00
