Trevor Buckner
6373c398bc
Fix scroll PR when no hash
2024-10-23 13:45:10 -04:00
Trevor Buckner
d5f498cbf9
Merge branch 'master' into scroll-to-element
2024-10-22 14:09:49 -04:00
Trevor Buckner
5040b9528f
cleanup
2024-10-22 14:08:20 -04:00
Trevor Buckner
83a48b8d0c
Simplify observer
2024-10-22 13:58:35 -04:00
Trevor Buckner
9fbdd24d01
Cleanup
2024-10-22 13:52:34 -04:00
Trevor Buckner
5b136f651c
Call scrollToHash from our existing "frameDidMount`
...
`frameDidMount` is equivalent to using iframe.addEventListener('load');
Let's not add a new listener and just use the existing event we already have. Functionality still works.
2024-10-22 13:03:12 -04:00
Trevor Buckner
ac766f3b37
Update brewRenderer.jsx
2024-10-18 10:23:56 -04:00
Víctor Losada Hernández
d872a496a7
fix mutation observer integration
2024-10-17 23:38:11 +02:00
Víctor Losada Hernández
9a4473526a
move around 2
2024-10-17 22:59:29 +02:00
Víctor Losada Hernández
5077fda3f6
move stuff around for minimal changes
2024-10-17 22:58:14 +02:00
Víctor Losada Hernández
397ae31f56
remove stale changes
2024-10-17 22:56:58 +02:00
Víctor Losada Hernández
87915ef0ef
remove unnecessary changes
2024-10-17 22:42:55 +02:00
Víctor Losada Hernández
ccfd5578cf
Merge branch 'master' of https://github.com/naturalcrit/homebrewery into scroll-to-element
2024-10-17 22:39:28 +02:00
Trevor Buckner
7888bfa878
Merge branch 'master' into tweakBrewRendererBackgroundStyle
2024-10-16 16:23:47 -04:00
Trevor Buckner
2aa60f793d
Fix /new
...
/new starts with no `text` so it will crash without `?.`
2024-10-15 22:39:13 -04:00
Trevor Buckner
321bbba4b8
Rearrange
2024-10-15 22:07:41 -04:00
Trevor Buckner
36af1cdb7f
Update brewRenderer.jsx
2024-10-15 21:47:27 -04:00
Víctor Losada Hernández
3c66907a86
Merge branch 'master' of https://github.com/naturalcrit/homebrewery into scroll-to-element
2024-10-13 11:15:15 +02:00
G.Ambatte
bec830c3b8
Tweak color of Brew Renderer background text
2024-10-12 08:09:51 +13:00
G.Ambatte
d534eddb29
Remove unnecessary useEffect import
2024-10-11 13:14:53 +13:00
G.Ambatte
9099db5ea1
Remove obsolete state and event handlers
2024-10-11 11:56:29 +13:00
G.Ambatte
a9a8b4b9bb
Shift static height style to LESS file
2024-10-11 11:55:51 +13:00
G.Ambatte
5d29d40c97
Implement suggested change
2024-10-11 11:42:03 +13:00
G.Ambatte
4291284252
Merge branch 'master' into experimentalDeploymentIdentification
2024-10-11 11:10:28 +13:00
Víctor Losada Hernández
6456c22c61
testing mutation Observer, don't review this yet
2024-10-09 21:33:26 +02:00
Trevor Buckner
ae123a8310
Change the other page number values as well
2024-09-27 11:35:01 -04:00
G.Ambatte
1f047890ab
Change default value of currentEditorCursorPageNum
2024-09-27 23:32:19 +12:00
Víctor Losada Hernández
2e5ebb861e
simplify logic
2024-09-17 19:50:39 +02:00
Víctor Losada Hernández
e92c169e71
Merge branch 'master' of https://github.com/naturalcrit/homebrewery into scroll-to-element
2024-09-16 23:01:40 +02:00
Trevor Buckner
c07c02f1d9
Remove unused variable
2024-09-15 21:44:02 -04:00
Trevor Buckner
85401ba71b
Fix BrewRenderer scrolling to 0
2024-09-15 21:26:49 -04:00
Víctor Losada Hernández
e213eb0a78
"Refactor BrewRenderer: removed iframe load event listener, simplified page scrolling logic, and inlined getPageContainingElement functionality"
2024-09-15 18:37:27 +02:00
Víctor Losada Hernández
422829cbd8
Merge branch 'master' of https://github.com/naturalcrit/homebrewery into scroll-to-element
2024-09-15 16:52:12 +02:00
Trevor Buckner
d4fa5d55d0
Merge branch 'master' into pr/3484
2024-09-14 19:15:12 -04:00
Trevor Buckner
76c9f2ee71
Lint
2024-09-14 18:58:23 -04:00
Trevor Buckner
fa2874b18f
Let brewRenderer pass changes up, and inherit values down
2024-09-14 18:50:38 -04:00
Trevor Buckner
3ef91cb1ea
Add check for scroll event complete/ lift page state up
2024-09-12 12:55:11 -04:00
David Bolack
7a37bf47c5
Bodge Render side mirroring back into place.
2024-09-07 21:33:51 -05:00
Víctor Losada Hernández
3360b4e829
refctor logic
2024-09-07 19:12:59 +02:00
Víctor Losada Hernández
9e1a532105
Merge branch 'master' of https://github.com/naturalcrit/homebrewery into scroll-to-element
2024-09-07 18:45:03 +02:00
G.Ambatte
cc7fe99760
Initial functionality pass
2024-08-29 21:26:24 +12:00
David Bolack
a4f30d687d
Merge branch 'master' into Issue_241_Part_II
2024-08-28 21:17:10 -05:00
Trevor Buckner
4b0b56dd35
Lint the jsx files
2024-08-24 23:55:17 -04:00
Trevor Buckner
3377d6645d
Tidy up brewRenderer
2024-08-24 23:53:44 -04:00
David Bolack
e27e61aaca
Bind livescrolling when done via scrollbars.
2024-08-24 00:47:06 -05:00
Gazook89
1f86b4c3d0
add mainRef back in
...
This was previously in the .pageInfo widget, probably not for any good reason, but I'm moving it to the popups div for probably not a good reason.
It's used to get the parent .pane div, and pull its `height` value which is then passed to the `.brewRenderer` div to set the height.
I tried alternate methods that would make this obsolete (CSS methods mostly), but due to some complexity am just ditching those alternatives and popping this sucker into `.popups` for now.
2024-08-23 22:41:12 -05:00
Gazook89
77421c2950
remove .pageInfo widget in bottom of preview
...
page counter function is in toolbar now, so this isn't necessary.
2024-08-23 19:25:49 -05:00
Gazook89
561ff6283a
remove redundant handleScroll() method
...
handleScroll is replaced by getCurrentPage(), which effectively does the same thing. The math is slightly different, though very similar, and result seems to be the same.
2024-08-23 18:33:14 -05:00
Gazook89
2246944dd2
Remove duplicate ErrorBar/popups tray
...
Removed duplicated components.
Restyled the popups to accomodate extra height of viewer tools.
2024-08-23 14:40:19 -05:00
Gazook89
83244485ab
Move scrollToPage to toolbar component
...
Keeps toolbar functions within the toolbar component and reduces props that need to be sent down.
2024-08-20 15:15:36 -05:00
