From fa7b3ea2a0b75ca88366941d6675be6cc0057453 Mon Sep 17 00:00:00 2001
From: "G.Ambatte" <sean@robertson-family.nz>
Date: Thu, 6 Jun 2024 21:41:33 +1200
Subject: [PATCH] Shift dismiss button, tweak local storage check

---
 client/components/dialog.jsx | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/client/components/dialog.jsx b/client/components/dialog.jsx
index 7bd4e5795..c37ed649c 100644
--- a/client/components/dialog.jsx
+++ b/client/components/dialog.jsx
@@ -3,11 +3,11 @@ const React = require('react');
 const { useState, useRef, useEffect } = React;
 
 function Dialog({ dismissKey, closeText = 'Close', blocking = false, ...rest }) {
-	const dialogRef = useRef();
+	const dialogRef = useRef(null);
 	const [open, setOpen] = useState(false);
 
 	useEffect(()=>{
-		if(!dismissKey || !localStorage.getItem(dismissKey)) {
+		if(!localStorage.getItem(dismissKey)) {
 			!open && setOpen(true);
 		}
 	}, []);
@@ -22,18 +22,16 @@ function Dialog({ dismissKey, closeText = 'Close', blocking = false, ...rest })
 
 	const dismiss = ()=>{
 		dismissKey && localStorage.setItem(dismissKey, true);
-		dialogRef.current?.close();
 		setOpen(false);
 	};
 
-	return (
-		<dialog ref={dialogRef} onCancel={dismiss} {...rest}>
-			<button className='dismiss' onClick={dismiss}>
-        	{closeText}
-			</button>
-			{rest.children}
-		</dialog>
-	);
-}
+	return <dialog ref={dialogRef} onCancel={dismiss} {...rest}>
+		{rest.children}
+		<button className='dismiss' onClick={dismiss}>
+			{closeText}
+		</button>
+	</dialog>
+	;
+};
 
 export default Dialog;
\ No newline at end of file