From 1556cf361ad2f82e8637be7b70a3670ba69877b3 Mon Sep 17 00:00:00 2001 From: Gazook89 Date: Wed, 27 Sep 2023 23:46:38 -0500 Subject: [PATCH 1/2] Check for author in author list before increasing views. --- server/app.js | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/server/app.js b/server/app.js index f10b6ff5e..4b9dd0528 100644 --- a/server/app.js +++ b/server/app.js @@ -327,14 +327,17 @@ app.get('/share/:id', asyncHandler(getBrew('share')), asyncHandler(async (req, r type : 'article' }; - if(req.params.id.length > 12 && !brew._id) { - const googleId = brew.googleId; - const shareId = brew.shareId; - await GoogleActions.increaseView(googleId, shareId, 'share', brew) - .catch((err)=>{next(err);}); - } else { - await HomebrewModel.increaseView({ shareId: brew.shareId }); - } + // increase visitor view count, do not include visits by author(s) + if(brew.authors.includes(req.account.username) === false){ + if(req.params.id.length > 12 && !brew._id) { + const googleId = brew.googleId; + const shareId = brew.shareId; + await GoogleActions.increaseView(googleId, shareId, 'share', brew) + .catch((err)=>{next(err);}); + } else { + await HomebrewModel.increaseView({ shareId: brew.shareId }); + } + }; sanitizeBrew(req.brew, 'share'); splitTextStyleAndMetadata(req.brew); return next(); From 3ac0ac7568bba51e85a9cb3c2fb9fa355ea38e88 Mon Sep 17 00:00:00 2001 From: Trevor Buckner Date: Fri, 13 Oct 2023 23:44:34 -0400 Subject: [PATCH 2/2] Fix crash when not logged in If not logged in, brew.authors doesn't exist, so visiting the share page crashes. --- server/app.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/app.js b/server/app.js index 4b9dd0528..a19030b3a 100644 --- a/server/app.js +++ b/server/app.js @@ -328,7 +328,7 @@ app.get('/share/:id', asyncHandler(getBrew('share')), asyncHandler(async (req, r }; // increase visitor view count, do not include visits by author(s) - if(brew.authors.includes(req.account.username) === false){ + if(!brew.authors.includes(req.account?.username)){ if(req.params.id.length > 12 && !brew._id) { const googleId = brew.googleId; const shareId = brew.shareId;