From f3a774d55cd609cc6681570eab3b2211184cf896 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Losada=20Hern=C3=A1ndez?= Date: Fri, 9 Aug 2024 22:46:25 +0200 Subject: [PATCH] "Removed unnecessary conditional statement in buildBrewsQuery function" --- server/vault.api.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/vault.api.js b/server/vault.api.js index 8714ad665..5be3b8307 100644 --- a/server/vault.api.js +++ b/server/vault.api.js @@ -36,6 +36,7 @@ const handleErrorResponse = (res, error, functionName) => { }; const buildBrewsQuery = (legacy, v3) => { + //first off, no need to include renderers, if all are valid if (legacy === 'true' && v3 === 'true') return { published: true }; const renderers = []; @@ -43,7 +44,7 @@ const buildBrewsQuery = (legacy, v3) => { if (v3 === 'true') renderers.push('V3'); const brewsQuery = { published: true }; - if (renderers.length > 0) brewsQuery.renderer = { $in: renderers }; + brewsQuery.renderer = { $in: renderers }; return brewsQuery; };