f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-10 13:32:45 +00:00
Code Wiki Activity

Remove loop on intersectionObserver entries

Browse Source 
Guaranteed to only be one entry each time, since we are attaching each page to its own observers.
This commit is contained in:
Trevor Buckner
2024-12-23 22:43:37 -05:00
parent d588a92147
commit f0e047e7cc
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
client/homebrew/brewRenderer/brewRenderer.jsx
View File

@@ -45,12 +45,10 @@ const BrewPage = (props)=>{
// Observer for tracking pages within the `.pages` div // Observer for tracking pages within the `.pages` div
const visibleObserver = new IntersectionObserver( const visibleObserver = new IntersectionObserver(
(entries)=>{ (entries)=>{
entries.forEach((entry)=>{ if(entries[0].isIntersecting)
if(entry.isIntersecting) props.onVisibilityChange(props.index + 1, true, false); // add page to array of visible pages.
props.onVisibilityChange(props.index + 1, true, false); // add page to array of visible pages. else
else props.onVisibilityChange(props.index + 1, false, false);
props.onVisibilityChange(props.index + 1, false, false);
});
}, },
{ threshold: .3, rootMargin: '0px 0px 0px 0px' } // detect when >30% of page is within bounds. { threshold: .3, rootMargin: '0px 0px 0px 0px' } // detect when >30% of page is within bounds.
); );
@@ -58,10 +56,8 @@ const BrewPage = (props)=>{
// Observer for tracking the page at the center of the iframe. // Observer for tracking the page at the center of the iframe.
const centerObserver = new IntersectionObserver( const centerObserver = new IntersectionObserver(
(entries)=>{ (entries)=>{
entries.forEach((entry)=>{ if(entries[0].isIntersecting)
if(entry.isIntersecting) props.onVisibilityChange(props.index + 1, true, true); // Set this page as the center page
props.onVisibilityChange(props.index + 1, true, true); // Set this page as the center page
});
}, },
{ threshold: 0, rootMargin: '-50% 0px -50% 0px' } // Detect when the page is at the center { threshold: 0, rootMargin: '-50% 0px -50% 0px' } // Detect when the page is at the center
); );