From e9cf7be488a44ccefc12a05414144ee2cdba92f3 Mon Sep 17 00:00:00 2001 From: Charlie Humphreys Date: Mon, 28 Mar 2022 20:43:45 -0500 Subject: [PATCH 1/3] add asyncHandler to async methods in routes --- server/homebrew.api.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/server/homebrew.api.js b/server/homebrew.api.js index 6faa69719..4415c948b 100644 --- a/server/homebrew.api.js +++ b/server/homebrew.api.js @@ -5,6 +5,7 @@ const zlib = require('zlib'); const GoogleActions = require('./googleActions.js'); const Markdown = require('../shared/naturalcrit/markdown.js'); const yaml = require('js-yaml'); +const asyncHandler = require('express-async-handler'); // const getTopBrews = (cb) => { // HomebrewModel.find().sort({ views: -1 }).limit(5).exec(function(err, brews) { @@ -226,10 +227,10 @@ const deleteGoogleBrew = async (account, id, res)=>{ return true; }; -router.post('/api', newBrew); -router.put('/api/:id', updateBrew); -router.put('/api/update/:id', updateBrew); -router.delete('/api/:id', deleteBrew); -router.get('/api/remove/:id', deleteBrew); +router.post('/api', asyncHandler(newBrew)); +router.put('/api/:id', asyncHandler(updateBrew)); +router.put('/api/update/:id', asyncHandler(updateBrew)); +router.delete('/api/:id', asyncHandler(deleteBrew)); +router.get('/api/remove/:id', asyncHandler(deleteBrew)); module.exports = router; From 89dbd19556e7040a95731aa4bf0bab73665dd518 Mon Sep 17 00:00:00 2001 From: Charlie Humphreys Date: Tue, 29 Mar 2022 11:46:50 -0500 Subject: [PATCH 2/3] update response handling for saving google brews --- client/homebrew/pages/editPage/editPage.jsx | 38 ++++++++++----------- client/homebrew/pages/newPage/newPage.jsx | 38 ++++++++++----------- 2 files changed, 38 insertions(+), 38 deletions(-) diff --git a/client/homebrew/pages/editPage/editPage.jsx b/client/homebrew/pages/editPage/editPage.jsx index fa985b7bf..ce9d73869 100644 --- a/client/homebrew/pages/editPage/editPage.jsx +++ b/client/homebrew/pages/editPage/editPage.jsx @@ -276,26 +276,26 @@ const EditPage = createClass({ console.log(errMsg); } catch (e){} - if(this.state.errors.status == '401'){ - return - Oops! -
- You must be signed in to a Google account - to save this to
Google Drive!
- -
- Sign In -
-
-
- Not Now -
-
-
; - } + // if(this.state.errors.status == '401'){ + // return + // Oops! + //
+ // You must be signed in to a Google account + // to save this to
Google Drive!
+ // + //
+ // Sign In + //
+ //
+ //
+ // Not Now + //
+ //
+ //
; + // } - if(this.state.errors.response.req.url.match(/^\/api\/.*Google.*$/m)){ + if(this.state.errors.response.req.url.match(/^\/api\/.*transfer.*$/m)){ return Oops!
diff --git a/client/homebrew/pages/newPage/newPage.jsx b/client/homebrew/pages/newPage/newPage.jsx index b57da013a..befc53a89 100644 --- a/client/homebrew/pages/newPage/newPage.jsx +++ b/client/homebrew/pages/newPage/newPage.jsx @@ -187,26 +187,26 @@ const NewPage = createClass({ console.log(errMsg); } catch (e){} - if(this.state.errors.status == '401'){ - return - Oops! -
- You must be signed in to a Google account - to save this to
Google Drive!
- -
- Sign In -
-
-
- Not Now -
-
-
; - } + // if(this.state.errors.status == '401'){ + // return + // Oops! + //
+ // You must be signed in to a Google account + // to save this to
Google Drive!
+ // + //
+ // Sign In + //
+ //
+ //
+ // Not Now + //
+ //
+ //
; + // } - if(this.state.errors.response.req.url.match(/^\/api\/.*Google.*$/m)){ + if(this.state.errors.response.req.url.match(/^\/api\/.*transfer.*$/m)){ return Oops!
From c17db043ba775b93c66b40d4f6d5e506e53c3b37 Mon Sep 17 00:00:00 2001 From: Charlie Humphreys Date: Tue, 29 Mar 2022 11:54:15 -0500 Subject: [PATCH 3/3] remove extra slash in regex --- client/homebrew/pages/editPage/editPage.jsx | 2 +- client/homebrew/pages/newPage/newPage.jsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/homebrew/pages/editPage/editPage.jsx b/client/homebrew/pages/editPage/editPage.jsx index ce9d73869..a77321e6f 100644 --- a/client/homebrew/pages/editPage/editPage.jsx +++ b/client/homebrew/pages/editPage/editPage.jsx @@ -295,7 +295,7 @@ const EditPage = createClass({ // ; // } - if(this.state.errors.response.req.url.match(/^\/api\/.*transfer.*$/m)){ + if(this.state.errors.response.req.url.match(/^\/api.*Google.*$/m)){ return Oops!
diff --git a/client/homebrew/pages/newPage/newPage.jsx b/client/homebrew/pages/newPage/newPage.jsx index befc53a89..cb8378bdd 100644 --- a/client/homebrew/pages/newPage/newPage.jsx +++ b/client/homebrew/pages/newPage/newPage.jsx @@ -206,7 +206,7 @@ const NewPage = createClass({ // ; // } - if(this.state.errors.response.req.url.match(/^\/api\/.*transfer.*$/m)){ + if(this.state.errors.response.req.url.match(/^\/api.*Google.*$/m)){ return Oops!