From 3e626d91f0fdeab9efc38daaaa33fdd802f7a8b3 Mon Sep 17 00:00:00 2001 From: "G.Ambatte" Date: Mon, 14 Nov 2022 08:12:27 +1300 Subject: [PATCH 1/2] Add empty object as ogMeta default --- server/app.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/app.js b/server/app.js index 7d462cf1e..535ae2669 100644 --- a/server/app.js +++ b/server/app.js @@ -415,7 +415,7 @@ app.use(asyncHandler(async (req, res, next)=>{ enable_v3 : config.get('enable_v3'), enable_themes : config.get('enable_themes'), config : configuration, - ogMeta : req.ogMeta + ogMeta : req.ogMeta ?? {} }; const title = req.brew ? req.brew.title : ''; const page = await templateFn('homebrew', title, props) From 3e3610a204ba4592afafcb5e5eba710b1e0c445f Mon Sep 17 00:00:00 2001 From: "G.Ambatte" Date: Mon, 14 Nov 2022 08:20:46 +1300 Subject: [PATCH 2/2] Move fix to template.js --- client/template.js | 3 ++- server/app.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/client/template.js b/client/template.js index 13e09711c..cab4790b9 100644 --- a/client/template.js +++ b/client/template.js @@ -1,6 +1,7 @@ const template = async function(name, title='', props = {}){ const ogTags = []; - Object.entries(props.ogMeta).forEach(([key, value])=>{ + const ogMeta = props.ogMeta ?? {}; + Object.entries(ogMeta).forEach(([key, value])=>{ if(!value) return; const tag = ``; ogTags.push(tag); diff --git a/server/app.js b/server/app.js index 535ae2669..7d462cf1e 100644 --- a/server/app.js +++ b/server/app.js @@ -415,7 +415,7 @@ app.use(asyncHandler(async (req, res, next)=>{ enable_v3 : config.get('enable_v3'), enable_themes : config.get('enable_themes'), config : configuration, - ogMeta : req.ogMeta ?? {} + ogMeta : req.ogMeta }; const title = req.brew ? req.brew.title : ''; const page = await templateFn('homebrew', title, props)