diff --git a/Dockerfile b/Dockerfile
index 84652fbf9..17d02b01f 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:20-alpine
+FROM node:22-alpine
RUN apk --no-cache add git
ENV NODE_ENV=docker
@@ -9,7 +9,10 @@ WORKDIR /usr/src/app
# Copy package.json into the image, then run yarn install
# This improves caching so we don't have to download the dependencies every time the code changes
COPY package.json ./
+COPY config/docker.json usr/src/app/config
# --ignore-scripts tells yarn not to run postbuild. We run it explicitly later
+RUN node --version
+RUN npm --version
RUN npm install --ignore-scripts
# Bundle app source and build application
diff --git a/README.DOCKER.md b/README.DOCKER.md
index 356ac398a..4dfbef045 100644
--- a/README.DOCKER.md
+++ b/README.DOCKER.md
@@ -1,12 +1,119 @@
-# Running Homebrewery via Docker
+# Offline Install Instructions: Docker
-The repo includes a Dockerfile and a docker-compose.yml file.
+These instructions are for setting up a persistent instance of the Homebrewery application locally using Docker.
-To run the application via docker-compose.yml:
-`docker-compose up -d`
+If you intend to develop with Homebrewery, following the Homebrewery application section of this guide is not recommended. Using docker to deploy MongoDB locally for development is not a bad idea at all, however.
-To stop the application:
-`docker-compose down`
+# Install Docker
+
+## Docker Desktop (MacOS/Windows)
+
+Windows and Mac installs use Docker Desktop. Current install instructions are below.
+
+* [Mac](https://docs.docker.com/desktop/mac/install/)
+* [Windows](https://docs.docker.com/desktop/windows/install/)
+
+You can set up the docker engine to start on boot via the Docker desktop UI.
+
+## Docker Engine
+
+Linux installs use Docker Engine. Docker provides installers and instructions for several of the most common distrubutions. If you do not see yours listed, it is very likely supported indirectly by your distribution.
+
+* [Arch](https://docs.docker.com/desktop/setup/install/linux/archlinux/)
+* [CentOS](https://docs.docker.com/engine/install/centos/)
+* [Debian](https://docs.docker.com/engine/install/debian/)
+* [Fedora](https://docs.docker.com/engine/install/fedora/)
+* [RHEL](https://docs.docker.com/engine/install/rhel/)
+* [Ubuntu](https://docs.docker.com/engine/install/ubuntu/)
+
+### Post installation steps
+[Manage Docker as a non-root user (highly recommended)](https://docs.docker.com/engine/install/linux-postinstall/#manage-docker-as-a-non-root-user)
+[Enable Docker to start on boot (highly recommended)](https://docs.docker.com/engine/install/linux-postinstall/#configure-docker-to-start-on-boot)
+
+# Build Homebrewery Image
+
+Next we build the homebrewery docker image. Start by cloning the repository.
+
+```shell
+git clone https://github.com/naturalcrit/homebrewery.git
+cd homebrewery
+```
+
+Make an changes you need to `config/docker.json` then build the image. If it does not exist,the below as a template.
+
+```
+{
+"host" : "localhost:8000",
+"naturalcrit_url" : "local.naturalcrit.com:8010",
+"secret" : "secret",
+"web_port" : 8000,
+"enable_v3" : true,
+"mongodb_uri": "mongodb://172.17.0.2/homebrewery",
+"enable_themes" : true,
+}
+```
+
+```shell
+docker-compose build homebrewery
+```
+
+# Add Mongo container
+
+Once docker is installed and running, it is time to set up the containers. First up, Mongo.
+
+```shell
+docker run --name homebrewery-mongodb -d --restart unless-stopped -v mongodata:/data/db -p 27017:27017 mongo:latest
+```
+
+Older CPUs may run into an issue with AVX support.
+```
+WARNING: MongoDB 5.0+ requires a CPU with AVX support, and your current system does not appear to have that!
+ see https://jira.mongodb.org/browse/SERVER-54407
+ see also https://www.mongodb.com/community/forums/t/mongodb-5-0-cpu-intel-g4650-compatibility/116610/2
+ see also https://github.com/docker-library/mongo/issues/485#issuecomment-891991814
+```
+If you see a message similar to this, try using the bitnami mongo instead.
+
+```shell
+docker run --name homebrewery-mongodb -d --restart unless-stopped -v mongodata:/data/db -p 27017:27017 bitnami/mongo:latest
+```
+
+If your distribution is running on an arm device such as a Raspberry Pi, you will need to run the arm-built MongoDB v4.4.
+
+```shell
+docker run --name homebrewery-mongodb -d --restart unless-stopped -v mongodata:/data/db -p 27017:27017 arm64v8/mongo:4.4
+```
+
+## Run the Homebrewery Image
+```shell
+# Make sure you run this in the homebrewery directory
+docker run --name homebrewery-app -d --restart unless-stopped -e NODE_ENV=docker -v $(pwd)/config/docker.json:/usr/src/app/config/docker.json -p 8000:8000 docker.io/library/homebrewery:latest
+```
+
+## Updating the Image
+
+When Homebrewery code updates, your docker container will not automatically follow the changes. To do so you will need to rebuild your homebrewery image.
+
+First, return to your homebrewery clone (from Build Homebrewery Image above) or recreate the clone if you deleted your copy of the code.
+
+First, delete the existing image.
+
+```shell
+docker rm -f homebrewery-app
+```
+
+Next, update the clone's code to the latest version.
+
+```shell
+cd homebrewery
+git checkout master
+git pull upstream master
+```
+
+Finally, rebuild and restart the homebrewery image.
+
+```shell
+docker-compose build homebrewery
+docker run --name homebrewery-app -d --restart unless-stopped -e NODE_ENV=docker -v $(pwd)/config/docker.json:/usr/src/app/config/docker.json -p 8000:8000 docker.io/library/homebrewery:latest
+```
-To stop the application and remove all data:
-`docker-compose down -v`
diff --git a/client/components/dialog.jsx b/client/components/dialog.jsx
index 0cdda2dee..e88d06c99 100644
--- a/client/components/dialog.jsx
+++ b/client/components/dialog.jsx
@@ -6,10 +6,8 @@ function Dialog({ dismisskeys = [], closeText = 'Close', blocking = false, ...re
const dialogRef = useRef(null);
useEffect(()=>{
- if(dismisskeys.length !== 0) {
- blocking ? dialogRef.current?.showModal() : dialogRef.current?.show();
- }
- }, [dialogRef.current, dismisskeys]);
+ blocking ? dialogRef.current?.showModal() : dialogRef.current?.show();
+ }, []);
const dismiss = ()=>{
dismisskeys.forEach((key)=>{
diff --git a/client/homebrew/brewRenderer/errorBar/errorBar.jsx b/client/homebrew/brewRenderer/errorBar/errorBar.jsx
index d2f847306..78b36d70c 100644
--- a/client/homebrew/brewRenderer/errorBar/errorBar.jsx
+++ b/client/homebrew/brewRenderer/errorBar/errorBar.jsx
@@ -1,75 +1,53 @@
require('./errorBar.less');
const React = require('react');
-const createClass = require('create-react-class');
-const _ = require('lodash');
-const ErrorBar = createClass({
- displayName : 'ErrorBar',
- getDefaultProps : function() {
- return {
- errors : []
- };
- },
+import Dialog from '../../../components/dialog.jsx';
- hasOpenError : false,
- hasCloseError : false,
- hasMatchError : false,
+const DISMISS_BUTTON = ;
- renderErrors : function(){
- this.hasOpenError = false;
- this.hasCloseError = false;
- this.hasMatchError = false;
+const ErrorBar = (props)=>{
+ if(!props.errors.length) return null;
+ let hasOpenError = false, hasCloseError = false, hasMatchError = false;
+ props.errors.map((err)=>{
+ if(err.id === 'OPEN') hasOpenError = true;
+ if(err.id === 'CLOSE') hasCloseError = true;
+ if(err.id === 'MISMATCH') hasMatchError = true;
+ });
- const errors = _.map(this.props.errors, (err, idx)=>{
- if(err.id == 'OPEN') this.hasOpenError = true;
- if(err.id == 'CLOSE') this.hasCloseError = true;
- if(err.id == 'MISMATCH') this.hasMatchError = true;
- return
- Line {err.line} : {err.text}, '{err.type}' tag
- ;
- });
+ const renderErrors = ()=>(
+
+ {props.errors.map((err, idx)=>{
+ return -
+ Line {err.line} : {err.text}, '{err.type}' tag
+
;
+ })}
+
+ );
- return ;
- },
-
- renderProtip : function(){
- const msg = [];
- if(this.hasOpenError){
- msg.push(
- An unmatched opening tag means there's an opened tag that isn't closed. You need to close your tags, like this {'
'}. Make sure to match types!
- );
- }
-
- if(this.hasCloseError){
- msg.push(
- An unmatched closing tag means you closed a tag without opening it. Either remove it, or check to where you think you opened it.
-
);
- }
-
- if(this.hasMatchError){
- msg.push(
- A type mismatch means you closed a tag, but the last open tag was a different type.
-
);
- }
- return
+ const renderProtip = ()=>(
+
Protips!
- {msg}
- ;
- },
+ {hasOpenError &&
Unmatched opening tag. Close your tags, like this {'
'}. Match types!
}
+ {hasCloseError && Unmatched closing tag. Either remove it or check where it was opened.
}
+ {hasMatchError && Type mismatch. Closed a tag with a different type.
}
+
+ );
- render : function(){
- if(!this.props.errors.length) return null;
-
- return
-
-
There are HTML errors in your markup
-
If these aren't fixed your brew will not render properly when you print it to PDF or share it
- {this.renderErrors()}
+ return (
+
;
- }
-});
+ {renderProtip()}
+
+ );
+};
module.exports = ErrorBar;
diff --git a/client/homebrew/brewRenderer/errorBar/errorBar.less b/client/homebrew/brewRenderer/errorBar/errorBar.less
index f3f2dbaae..163648533 100644
--- a/client/homebrew/brewRenderer/errorBar/errorBar.less
+++ b/client/homebrew/brewRenderer/errorBar/errorBar.less
@@ -1,60 +1,58 @@
-.errorBar{
+.errorBar {
position : absolute;
- z-index : 10000;
- box-sizing : border-box;
+ top : 32px;
+ z-index : 1;
width : 100%;
- margin-right : 13px;
- padding : 20px;
- padding-bottom : 10px;
- padding-left : 100px;
- background-color : @red;
color : white;
- i{
- position : absolute;
- left : 30px;
- opacity : 0.8;
- font-size : 3em;
- }
- h3{
- font-size : 1.1em;
- font-weight : 800;
- }
- ul{
- margin-top : 15px;
- font-size : 0.8em;
- list-style-position : inside;
- list-style-type : disc;
- li{
- line-height : 1.6em;
+ background-color : @red;
+ border : unset;
+
+ div {
+ > i {
+ float : left;
+ margin-right : 10px;
+ margin-bottom : 20px;
+ font-size : 3em;
+ opacity : 0.8;
+ }
+ h2 { font-weight : 800; }
+ ul {
+ margin-top : 15px;
+ font-size : 0.8em;
+ list-style-position : inside;
+ list-style-type : disc;
+ li { line-height : 1.6em; }
}
}
- hr{
- box-sizing : border-box;
+ hr {
height : 2px;
- width : 150%;
margin-top : 25px;
margin-bottom : 15px;
- margin-left : -100px;
background-color : darken(@red, 8%);
border : none;
}
- small{
- font-size: 0.6em;
- opacity: 0.7;
+ small {
+ font-size : 0.6em;
+ opacity : 0.7;
}
- .protips{
- margin-left : -80px;
- font-size : 0.6em;
- &>div{
- margin-bottom : 10px;
- line-height : 1.2em;
- }
- h4{
- opacity : 0.8;
+ .protips {
+ font-size : 0.6em;
+ line-height : 1.2em;
+ h4 {
font-weight : 800;
line-height : 1.5em;
text-transform : uppercase;
}
}
+ button.dismiss {
+ position : absolute;
+ top : 20px;
+ right : 30px;
+ padding : unset;
+ font-size : 40px;
+ background-color : transparent;
+ opacity : 0.6;
+ &:hover { opacity : 1; }
+ }
}
\ No newline at end of file
diff --git a/client/homebrew/brewRenderer/notificationPopup/notificationPopup.jsx b/client/homebrew/brewRenderer/notificationPopup/notificationPopup.jsx
index 0c8fc4b8c..b2045f13d 100644
--- a/client/homebrew/brewRenderer/notificationPopup/notificationPopup.jsx
+++ b/client/homebrew/brewRenderer/notificationPopup/notificationPopup.jsx
@@ -49,6 +49,7 @@ const NotificationPopup = ()=>{
));
};
+ if(!notifications.length) return;
return