f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-08-06 06:47:38 +00:00
Code Wiki Activity

Merge pull request #4932 from firstmatekidd/a11y_nav_kbd

Browse Source 
Add nav buttons to the tab order and use semantic buttons so they are interactable with the keyboard
This commit is contained in:
Víctor Losada Hernández
2026-07-27 12:18:08 +02:00
committed by GitHub
parent 98117dae0e 3628d1d57d
commit d3b0739a53
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/homebrew/navbar/nav.jsx
+2 -2
View File
@@ -61,10 +61,10 @@ const Nav = {
{icon} {icon}
</a>; </a>;
} else { } else {
return <div {...props} className={classes} onClick={this.handleClick} > return <button {...props} className={classes} onClick={this.handleClick} >
{this.props.children} {this.props.children}
{icon} {icon}
</div>; </button>;
} }
} }
}), }),
client/homebrew/pages/editPage/editPage.jsx
+1 -1
View File
@@ -320,7 +320,7 @@ const EditPage = (props)=>{
// #5 - No unsaved changes, and has never been saved, hide the button // #5 - No unsaved changes, and has never been saved, hide the button
if(neverSaved) if(neverSaved)
return <Nav.item className='save neverSaved'>save now</Nav.item>; return <Nav.item className='save neverSaved' disabled={true}>save now</Nav.item>;
// DEFAULT - No unsaved changes, show SAVED // DEFAULT - No unsaved changes, show SAVED
return <Nav.item className='save saved'>saved</Nav.item>; return <Nav.item className='save saved'>saved</Nav.item>;
client/homebrew/pages/homePage/homePage.jsx
+1 -1
View File
@@ -164,7 +164,7 @@ const HomePage =(props)=>{
// #5 - No unsaved changes, and has never been saved, hide the button // #5 - No unsaved changes, and has never been saved, hide the button
if(neverSaved) if(neverSaved)
return <Nav.item className='save neverSaved'>save now</Nav.item>; return <Nav.item className='save neverSaved' disabled={true}>save now</Nav.item>;
// DEFAULT - No unsaved changes, show SAVED // DEFAULT - No unsaved changes, show SAVED
return <Nav.item className='save saved'>saved</Nav.item>; return <Nav.item className='save saved'>saved</Nav.item>;
client/homebrew/pages/newPage/newPage.jsx
+1 -1
View File
@@ -207,7 +207,7 @@ const NewPage = (props)=>{
// #5 - No unsaved changes, and has never been saved, hide the button // #5 - No unsaved changes, and has never been saved, hide the button
if(neverSaved) if(neverSaved)
return <Nav.item className='save neverSaved'>save now</Nav.item>; return <Nav.item className='save neverSaved' disabled={true}>save now</Nav.item>;
// DEFAULT - No unsaved changes, show SAVED // DEFAULT - No unsaved changes, show SAVED
return <Nav.item className='save saved'>saved</Nav.item>; return <Nav.item className='save saved'>saved</Nav.item>;