mirror of
https://github.com/naturalcrit/homebrewery.git
synced 2026-01-02 08:32:41 +00:00
Merge branch 'master' into GlobalToCToggles
This commit is contained in:
36
.github/pull_request_template.md
vendored
Normal file
36
.github/pull_request_template.md
vendored
Normal file
@@ -0,0 +1,36 @@
|
|||||||
|
<!--
|
||||||
|
Before submitting a Pull Request, please consider the following to speed up reviews:
|
||||||
|
- 👷♀️ Create small PRs. Large PRs can usually be broken down into incremental PRs.
|
||||||
|
- 🚩 Do you already have several open PRs? Consider finishing or asking for help with existing PRs first.
|
||||||
|
- 🔧 Does your PR reference a discussed and approved issue, especially for personal or edge-case requests?
|
||||||
|
- 💡 Is the solution agreed upon? Save rework time by discussing strategy before coding.
|
||||||
|
-->
|
||||||
|
|
||||||
|
## Description
|
||||||
|
|
||||||
|
|
||||||
|
## Related Issues or Discussions
|
||||||
|
|
||||||
|
- Closes #
|
||||||
|
|
||||||
|
## QA Instructions, Screenshots, Recordings
|
||||||
|
|
||||||
|
_Please replace this line with instructions on how to test or view your changes, as well as any before/after
|
||||||
|
images for UI changes._
|
||||||
|
|
||||||
|
### Reviewer Checklist
|
||||||
|
|
||||||
|
_Please replace the list below with specific features you want reviewers to look at._
|
||||||
|
|
||||||
|
*Reviewers, refer to this list when testing features, or suggest new items *
|
||||||
|
- [ ] Verify new features are functional
|
||||||
|
- [ ] Feature A does X
|
||||||
|
- [ ] Feature B does Y
|
||||||
|
- [ ] Verify old features have not broken
|
||||||
|
- [ ] Feature Z can still be used
|
||||||
|
- [ ] Test for edge cases / try to break things
|
||||||
|
- [ ] Feature A handles negative numbers
|
||||||
|
- [ ] Identify opportunities for simplification and refactoring
|
||||||
|
- [ ] Check for code legibility and appropriate comments
|
||||||
|
|
||||||
|
<details><summary>Copy this list</summary>
|
||||||
@@ -70,7 +70,7 @@ const Snippetbar = createClass({
|
|||||||
mergeCustomizer : function(oldValue, newValue, key) {
|
mergeCustomizer : function(oldValue, newValue, key) {
|
||||||
if(key == 'snippets') {
|
if(key == 'snippets') {
|
||||||
const result = _.reverse(_.unionBy(_.reverse(newValue), _.reverse(oldValue), 'name')); // Join snippets together, with preference for the child theme over the parent theme
|
const result = _.reverse(_.unionBy(_.reverse(newValue), _.reverse(oldValue), 'name')); // Join snippets together, with preference for the child theme over the parent theme
|
||||||
return _.filter(result, 'gen'); //Only keep snippets with a 'gen' property.
|
return result.filter(snip.gen || snip.subsnippets);
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user