f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-19 14:12:40 +00:00
Code Wiki Activity

"Refactor BrewRenderer: updated iframe handling and scrolling logic in useEffect and scrollToPage function"

Browse Source
This commit is contained in:
Víctor Losada Hernández
2024-05-31 17:06:47 +02:00
parent 3cca38302a
commit d012a09346
1 changed files with 15 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
client/homebrew/brewRenderer/brewRenderer.jsx
View File

@@ -85,12 +85,7 @@ const BrewRenderer = (props)=>{
if (pageIdRegex.test(locationHash)) { if (pageIdRegex.test(locationHash)) {
// Extract page number from the ID // Extract page number from the ID
const pageNumber = parseInt(locationHash.slice(2)); const pageNumber = parseInt(locationHash.slice(2));
console.log('scrolling to page ', pageNumber);
if (!isNaN(pageNumber)) {
scrollToPage(iframe, pageNumber); scrollToPage(iframe, pageNumber);
} else {
console.error('Invalid page ID:', locationHash);
}
} else { } else {
// Treat it as an element ID // Treat it as an element ID
const elementId = locationHash.slice(1); // Remove the leading '#' const elementId = locationHash.slice(1); // Remove the leading '#'
@@ -118,10 +113,13 @@ const BrewRenderer = (props)=>{
const scrollToPage = (iframe, pageNumber) => { const scrollToPage = (iframe, pageNumber) => {
if (iframe && iframe.contentWindow) { if (iframe && iframe.contentWindow) {
const brewRenderer = iframe.contentWindow.document.querySelector('.brewRenderer'); const brewRenderer =
iframe.contentWindow.document.querySelector('.brewRenderer');
if (brewRenderer) { if (brewRenderer) {
const pages = brewRenderer.querySelectorAll('.page'); const pages = brewRenderer.querySelectorAll('.page');
if (pages && pages[pageNumber]) { if (pageNumber > pages.length) {
console.log('page not found');
} else {
pages[pageNumber].scrollIntoView({ block: 'start' }); pages[pageNumber].scrollIntoView({ block: 'start' });
} }
} }