From 1bfcb5a8394ed816f63ee52abebcb0ccba0cd173 Mon Sep 17 00:00:00 2001 From: Gazook89 <58999374+Gazook89@users.noreply.github.com> Date: Sun, 18 Sep 2022 19:25:26 -0500 Subject: [PATCH 1/6] fix 'validations' on general_issue.yaml --- .github/ISSUE_TEMPLATE/general_issue.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/general_issue.yml b/.github/ISSUE_TEMPLATE/general_issue.yml index 92319ad56..9398b5277 100644 --- a/.github/ISSUE_TEMPLATE/general_issue.yml +++ b/.github/ISSUE_TEMPLATE/general_issue.yml @@ -25,8 +25,8 @@ body: - label: Edge - label: Safari - label: other - validations: - required: true + validations: + required: true - type: dropdown id: operating-system attributes: From 2e27c5957d25142b09295c4f4b232fefb950efd3 Mon Sep 17 00:00:00 2001 From: Gazook89 <58999374+Gazook89@users.noreply.github.com> Date: Sun, 18 Sep 2022 19:30:30 -0500 Subject: [PATCH 2/6] fix checkboxes on feature_request.yml --- .github/ISSUE_TEMPLATE/feature_request.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index 6851abb40..e25f72b55 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -4,8 +4,7 @@ labels: ["feature request"] body: - type: markdown attributes: - value: | - "We'd love to hear your idea! Please be sure to [search the current Issues](https://github.com/naturalcrit/homebrewery/issues) for any duplicate requests." + value: "We'd love to hear your idea! Please be sure to [search the current Issues](https://github.com/naturalcrit/homebrewery/issues) for any duplicate requests." - type: textarea id: user-request attributes: @@ -15,6 +14,7 @@ body: required: true - type: checkboxes id: terms - options: - - label: I have searched the Issues tracker for any duplicate requests and found none. - required: true \ No newline at end of file + attributes: + options: + - label: I have searched the Issues tracker for any duplicate requests and found none. + required: true \ No newline at end of file From d8039b0cf2ce0d444214f4c1931de0aca84961be Mon Sep 17 00:00:00 2001 From: Gazook89 <58999374+Gazook89@users.noreply.github.com> Date: Sun, 18 Sep 2022 19:32:15 -0500 Subject: [PATCH 3/6] removed 'title' from save_issue.yml --- .github/ISSUE_TEMPLATE/save_issue.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/save_issue.yml b/.github/ISSUE_TEMPLATE/save_issue.yml index 09136f0a7..86b68066f 100644 --- a/.github/ISSUE_TEMPLATE/save_issue.yml +++ b/.github/ISSUE_TEMPLATE/save_issue.yml @@ -1,6 +1,5 @@ name: Saving Issue description: Report an issue Saving -title: "Save Error: " labels: ["saving"] body: - type: markdown From 0d931ed5b563dbbbc99081c7739e8ab9c6a82998 Mon Sep 17 00:00:00 2001 From: Gazook89 <58999374+Gazook89@users.noreply.github.com> Date: Sun, 18 Sep 2022 19:33:53 -0500 Subject: [PATCH 4/6] add validation (required) to user-description in save_issue.yml --- .github/ISSUE_TEMPLATE/save_issue.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/save_issue.yml b/.github/ISSUE_TEMPLATE/save_issue.yml index 86b68066f..8e246d6bf 100644 --- a/.github/ISSUE_TEMPLATE/save_issue.yml +++ b/.github/ISSUE_TEMPLATE/save_issue.yml @@ -15,6 +15,8 @@ body: id: user-description attributes: label: "Your description of what happened:" + validations: + required: true - type: markdown attributes: value: | From af8d327ae26a68999bd5974d3012bca9abafb601 Mon Sep 17 00:00:00 2001 From: Gazook89 <58999374+Gazook89@users.noreply.github.com> Date: Sun, 18 Sep 2022 19:37:40 -0500 Subject: [PATCH 5/6] fix editPage url query & Saving label --- .github/ISSUE_TEMPLATE/save_issue.yml | 2 +- client/homebrew/pages/editPage/editPage.jsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/save_issue.yml b/.github/ISSUE_TEMPLATE/save_issue.yml index 8e246d6bf..c08f485ce 100644 --- a/.github/ISSUE_TEMPLATE/save_issue.yml +++ b/.github/ISSUE_TEMPLATE/save_issue.yml @@ -1,6 +1,6 @@ name: Saving Issue description: Report an issue Saving -labels: ["saving"] +labels: ["Saving"] body: - type: markdown attributes: diff --git a/client/homebrew/pages/editPage/editPage.jsx b/client/homebrew/pages/editPage/editPage.jsx index 19b33f148..d6a20527e 100644 --- a/client/homebrew/pages/editPage/editPage.jsx +++ b/client/homebrew/pages/editPage/editPage.jsx @@ -322,7 +322,7 @@ const EditPage = createClass({
Looks like there was a problem saving.
Report the issue + href={`https://github.com/naturalcrit/homebrewery/issues/new?template=save_issue.yml&error-code=${encodeURIComponent(errMsg)}`}> here .
From 208e9261ce0f51f44d006c22571d59ba769abbcf Mon Sep 17 00:00:00 2001 From: Gazook89 <58999374+Gazook89@users.noreply.github.com> Date: Mon, 19 Sep 2022 09:31:55 -0500 Subject: [PATCH 6/6] fixed two more validations --- .github/ISSUE_TEMPLATE/general_issue.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/general_issue.yml b/.github/ISSUE_TEMPLATE/general_issue.yml index 9398b5277..c718daccc 100644 --- a/.github/ISSUE_TEMPLATE/general_issue.yml +++ b/.github/ISSUE_TEMPLATE/general_issue.yml @@ -12,8 +12,8 @@ body: options: - label: Legacy - label: v3 - validations: - required: true + validations: + required: true - type: dropdown id: browser attributes: @@ -37,8 +37,8 @@ body: - label: MacOS - label: Linux - label: other - validations: - required: true + validations: + required: true - type: textarea id: user-description attributes: