From a26831e11185f1e17a49060a25866a1e04f987fa Mon Sep 17 00:00:00 2001 From: Trevor Buckner Date: Wed, 23 Sep 2026 19:07:46 +0000 Subject: [PATCH 1/4] Remove currentBrewRendererPageNum from brewRenderer --- client/homebrew/brewRenderer/brewRenderer.jsx | 3 +-- client/homebrew/pages/editPage/editPage.jsx | 1 - client/homebrew/pages/homePage/homePage.jsx | 1 - client/homebrew/pages/newPage/newPage.jsx | 1 - client/homebrew/pages/sharePage/sharePage.jsx | 1 - 5 files changed, 1 insertion(+), 6 deletions(-) diff --git a/client/homebrew/brewRenderer/brewRenderer.jsx b/client/homebrew/brewRenderer/brewRenderer.jsx index 618a64ecd..4d0b904a5 100644 --- a/client/homebrew/brewRenderer/brewRenderer.jsx +++ b/client/homebrew/brewRenderer/brewRenderer.jsx @@ -96,7 +96,6 @@ const BrewRenderer = (props)=>{ lang : '', errors : [], currentEditorCursorPageNum : 1, - currentBrewRendererPageNum : 1, themeBundle : {}, onPageChange : ()=>{}, ...props @@ -154,7 +153,7 @@ const BrewRenderer = (props)=>{ if(index == props.currentEditorCursorPageNum - 1) //Already rendered before this step return false; - if(Math.abs(index - props.currentBrewRendererPageNum - 1) <= 3) + if(Math.abs(index - centerPage - 1) <= 3) return true; return false; diff --git a/client/homebrew/pages/editPage/editPage.jsx b/client/homebrew/pages/editPage/editPage.jsx index 4033d0193..dbf3ac9cb 100644 --- a/client/homebrew/pages/editPage/editPage.jsx +++ b/client/homebrew/pages/editPage/editPage.jsx @@ -294,7 +294,6 @@ const EditPage = (props)=>{ lang={currentBrew.lang} onPageChange={setCurrentBrewRendererPageNum} currentEditorCursorPageNum={currentEditorCursorPageNum} - currentBrewRendererPageNum={currentBrewRendererPageNum} allowPrint={true} /> diff --git a/client/homebrew/pages/homePage/homePage.jsx b/client/homebrew/pages/homePage/homePage.jsx index ef2853792..1d35ef0e1 100644 --- a/client/homebrew/pages/homePage/homePage.jsx +++ b/client/homebrew/pages/homePage/homePage.jsx @@ -141,7 +141,6 @@ const HomePage =(props)=>{ themeBundle={themeBundle} onPageChange={setCurrentBrewRendererPageNum} currentEditorCursorPageNum={currentEditorCursorPageNum} - currentBrewRendererPageNum={currentBrewRendererPageNum} /> diff --git a/client/homebrew/pages/newPage/newPage.jsx b/client/homebrew/pages/newPage/newPage.jsx index c4eee3e8d..edf4d2125 100644 --- a/client/homebrew/pages/newPage/newPage.jsx +++ b/client/homebrew/pages/newPage/newPage.jsx @@ -188,7 +188,6 @@ const NewPage = (props)=>{ lang={currentBrew.lang} onPageChange={setCurrentBrewRendererPageNum} currentEditorCursorPageNum={currentEditorCursorPageNum} - currentBrewRendererPageNum={currentBrewRendererPageNum} allowPrint={true} /> diff --git a/client/homebrew/pages/sharePage/sharePage.jsx b/client/homebrew/pages/sharePage/sharePage.jsx index 99ef3e35c..5280fc850 100644 --- a/client/homebrew/pages/sharePage/sharePage.jsx +++ b/client/homebrew/pages/sharePage/sharePage.jsx @@ -149,7 +149,6 @@ const SharePage = (props)=>{ theme={currentBrew.theme} themeBundle={themeBundle} onPageChange={handleBrewRendererPageChange} - currentBrewRendererPageNum={currentBrewRendererPageNum} allowPrint={true} /> From eb485755981b1398b49f890b1ecb39b51d5480dd Mon Sep 17 00:00:00 2001 From: Trevor Buckner Date: Wed, 23 Sep 2026 19:13:20 +0000 Subject: [PATCH 2/4] clean up stray syntax --- client/homebrew/brewRenderer/brewRenderer.jsx | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/client/homebrew/brewRenderer/brewRenderer.jsx b/client/homebrew/brewRenderer/brewRenderer.jsx index 4d0b904a5..7d824f4db 100644 --- a/client/homebrew/brewRenderer/brewRenderer.jsx +++ b/client/homebrew/brewRenderer/brewRenderer.jsx @@ -159,11 +159,10 @@ const BrewRenderer = (props)=>{ return false; }; - const renderDummyPage = (index)=>{ - return
+ const renderDummyPage = (index)=> +
; - }; const renderStyle = ()=>{ const themeStyles = props.themeBundle?.joinedStyles ?? ''; From 7339892d0409d2189de662ec5b6901759d8f4d37 Mon Sep 17 00:00:00 2001 From: Trevor Buckner Date: Wed, 23 Sep 2026 19:16:20 +0000 Subject: [PATCH 3/4] stray syntax --- client/homebrew/brewRenderer/brewRenderer.jsx | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/client/homebrew/brewRenderer/brewRenderer.jsx b/client/homebrew/brewRenderer/brewRenderer.jsx index 7d824f4db..b120de842 100644 --- a/client/homebrew/brewRenderer/brewRenderer.jsx +++ b/client/homebrew/brewRenderer/brewRenderer.jsx @@ -221,8 +221,7 @@ const BrewRenderer = (props)=>{ }; const renderPages = (checkHoists = false)=>{ - - if(props.errors && props.errors.length) + if(props.errors?.length) return renderedPages; if(rawPages.length != renderedPages.length) { // Re-render all pages when page count changes @@ -244,7 +243,7 @@ const BrewRenderer = (props)=>{ renderedPages[index] = renderPage(page, index); // Render any page not yet rendered, but only re-render those in PPR range } }); - if(!props.hoisted) { props.hoisted = true; } // Only fully hoist once. + props.hoisted = true; // Only fully hoist once. return renderedPages; }; From 220047ffc7b874a6f273da207c7bbbca86412225 Mon Sep 17 00:00:00 2001 From: Trevor Buckner Date: Wed, 23 Sep 2026 19:21:36 +0000 Subject: [PATCH 4/4] stray syntax --- client/homebrew/brewRenderer/brewRenderer.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/homebrew/brewRenderer/brewRenderer.jsx b/client/homebrew/brewRenderer/brewRenderer.jsx index b120de842..f3b9052c9 100644 --- a/client/homebrew/brewRenderer/brewRenderer.jsx +++ b/client/homebrew/brewRenderer/brewRenderer.jsx @@ -334,7 +334,7 @@ const BrewRenderer = (props)=>{ {emitClick();}} + onClick={emitClick} sandbox='allow-same-origin allow-modals allow-top-navigation' >