From d200d4a48ac12cade9f4ce100693f6851aeb2c49 Mon Sep 17 00:00:00 2001
From: Trevor Buckner <calculuschild@gmail.com>
Date: Wed, 21 Oct 2026 18:52:49 +0000
Subject: [PATCH] Small cleanup of migrateSystemsToTags

---
 server/homebrew.api.js | 21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)

diff --git a/server/homebrew.api.js b/server/homebrew.api.js
index b3a0e8332..d76969fb5 100644
--- a/server/homebrew.api.js
+++ b/server/homebrew.api.js
@@ -27,17 +27,8 @@ const isStaticTheme = (renderer, themeName)=>{
 	return Themes[renderer]?.[themeName] !== undefined;
 };
 
-// const getTopBrews = (cb) => {
-// 	HomebrewModel.find().sort({ views: -1 }).limit(5).exec(function(err, brews) {
-// 		cb(brews);
-// 	});
-// };
-
-
 const migrateSystemsToTags = (brew)=>{
-	if(!('systems' in brew)) return brew;
-
-	if(!Array.isArray(brew.systems) || brew.systems.length === 0) {
+	if(!('systems' in brew) || !Array.isArray(brew.systems) || brew.systems.length === 0) {
 		brew.systems = undefined;
 		return brew;
 	}
@@ -189,10 +180,7 @@ const api = {
 			stub.renderer = stub.renderer || undefined; // Clear empty strings
 			stub = _.defaults(stub, DEFAULT_BREW_LOAD); // Fill in blank fields
 
-
-
-			const fixedStub = migrateSystemsToTags(stub);
-			req.brew = fixedStub;
+			req.brew = migrateSystemsToTags(stub);
 			splitTextStyleAndMetadata(req.brew);
 			next();
 		};
@@ -412,10 +400,9 @@ const api = {
 			// throw err; // rethrow to preserve the 500 behavior
 		}
 
-		let brew         = _.assign(brewFromServer, brewFromClient);
-
-		migrateSystemsToTags(brew);
+		let brew = _.assign(brewFromServer, brewFromClient);
 
+		brew             = migrateSystemsToTags(brew);
 		brew.title       = brew.title.trim();
 		brew.description = brew.description.trim() || '';
 		brew.text        = api.mergeBrewText(brew);