f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-08 18:22:40 +00:00
Code Wiki Activity

"Removed iframe parameter from scrollToPage and getPageContainingElement functions, instead getting iframe element by id 'BrewRenderer' inside the functions."

Browse Source
This commit is contained in:
Víctor Losada Hernández
2024-05-31 17:13:29 +02:00
parent d012a09346
commit acbdd1b801
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
client/homebrew/brewRenderer/brewRenderer.jsx
View File

@@ -85,15 +85,15 @@ const BrewRenderer = (props)=>{
if (pageIdRegex.test(locationHash)) { if (pageIdRegex.test(locationHash)) {
// Extract page number from the ID // Extract page number from the ID
const pageNumber = parseInt(locationHash.slice(2)); const pageNumber = parseInt(locationHash.slice(2));
scrollToPage(iframe, pageNumber); scrollToPage(pageNumber);
} else { } else {
// Treat it as an element ID // Treat it as an element ID
const elementId = locationHash.slice(1); // Remove the leading '#' const elementId = locationHash.slice(1); // Remove the leading '#'
if (elementId) { if (elementId) {
getPageContainingElement(iframe, elementId) getPageContainingElement(elementId)
.then((pageNumber) => { .then((pageNumber) => {
if (pageNumber !== -1) { if (pageNumber !== -1) {
scrollToPage(iframe, pageNumber); scrollToPage(pageNumber);
} }
}) })
.catch((error) => { .catch((error) => {
@@ -111,7 +111,8 @@ const BrewRenderer = (props)=>{
}, []); }, []);
const scrollToPage = (iframe, pageNumber) => { const scrollToPage = (pageNumber) => {
const iframe = document.getElementById('BrewRenderer');
if (iframe && iframe.contentWindow) { if (iframe && iframe.contentWindow) {
const brewRenderer = const brewRenderer =
iframe.contentWindow.document.querySelector('.brewRenderer'); iframe.contentWindow.document.querySelector('.brewRenderer');
@@ -126,7 +127,8 @@ const BrewRenderer = (props)=>{
} }
}; };
const getPageContainingElement = (iframe, elementId) => { const getPageContainingElement = (elementId) => {
const iframe = document.getElementById('BrewRenderer');
return new Promise((resolve) => { return new Promise((resolve) => {
const brewRenderer = const brewRenderer =
iframe.contentWindow.document.querySelector('.brewRenderer'); iframe.contentWindow.document.querySelector('.brewRenderer');