f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-06 03:32:40 +00:00
Code Wiki Activity

Fix regression with updated Pico-Router

Browse Source 
This variable name changed with the v2.0.0 of Pico-Router and it wasn't changed here. This was causing every page to display a  `<div class="homePage page">` rather than the appropriate `editPage` or `sharePage`. It just wasn't immediately noticeable since `homePage` and `editPage` are almost identical. The problem is clearly visible on `sharePage` however.

`homebrew.jsx` was set to always render a defaultUrl of ` ` which creates a `<div class="homePage page">` by default, overwriting the expected `<div>` on for the current url.
This commit is contained in:
Trevor Buckner
2018-05-23 08:53:30 -04:00
parent c8585775be
commit a06236e3ff
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
client/homebrew/homebrew.jsx
View File

@@ -82,7 +82,7 @@ const Homebrew = createClass({
}, },
render : function(){ render : function(){
return <div className='homebrew'> return <div className='homebrew'>
<Router initialUrl={this.props.url}/> <Router defaultUrl={this.props.url}/>
</div>; </div>;
} }
}); });