From 94f478477d01ce586106f1ee3adae8eefab0636e Mon Sep 17 00:00:00 2001
From: Trevor Buckner <calculuschild@gmail.com>
Date: Thu, 13 Feb 2025 16:20:50 -0500
Subject: [PATCH] Add test for missing meta:theme tag

---
 server/homebrew.api.js      |  2 +-
 server/homebrew.api.spec.js | 21 +++++++++++++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/server/homebrew.api.js b/server/homebrew.api.js
index 7c5460803..7bd88cbdb 100644
--- a/server/homebrew.api.js
+++ b/server/homebrew.api.js
@@ -295,7 +295,7 @@ const api = {
 				currentTheme = req.brew;
 				splitTextStyleAndMetadata(currentTheme);
 				if(!currentTheme.tags.some(tag => tag === "meta:theme" || tag === "meta:Theme"))
-					throw { brewId: req.params.id, name: 'Invalid Theme Selected', message: 'Selected theme does not have the meta:theme tag', HBErrorCode: '10' };
+					throw { brewId: req.params.id, name: 'Invalid Theme Selected', message: 'Selected theme does not have the meta:theme tag', status: 422, HBErrorCode: '10' };
 				themeName   ??= currentTheme.title;
 				themeAuthor ??= currentTheme.authors?.[0];
 
diff --git a/server/homebrew.api.spec.js b/server/homebrew.api.spec.js
index d6433bced..cfa7d13cc 100644
--- a/server/homebrew.api.spec.js
+++ b/server/homebrew.api.spec.js
@@ -690,6 +690,27 @@ brew`);
 				name        : 'ThemeLoad Error',
 				status      : 404 });
 		});
+
+		it('should fail for a User Theme not tagged with meta:theme', async ()=>{
+			const brews = {
+				userThemeAID : { title: 'User Theme A', renderer: 'V3', theme: null, shareId: 'userThemeAID', style: 'User Theme A Style' }
+			};
+
+			const toBrewPromise = (brew)=>new Promise((res)=>res({ toObject: ()=>brew }));
+			model.get = jest.fn((getParams)=>toBrewPromise(brews[getParams.shareId]));
+			const req = { params: { renderer: 'V3', id: 'userThemeAID' }, get: ()=>{ return 'localhost'; }, protocol: 'https' };
+
+			let err;
+			await api.getThemeBundle(req, res)
+			.catch((e)=>err = e);
+
+			expect(err).toEqual({
+				HBErrorCode : '10',
+				brewId      : 'userThemeAID',
+				message     : 'Selected theme does not have the meta:theme tag',
+				name        : 'Invalid Theme Selected',
+				status      : 422 });
+		});
 	});
 
 	describe('deleteBrew', ()=>{