f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-05 23:12:39 +00:00
Code Wiki Activity

rename functions/attributes

Browse Source 
updateZoom() => handleZoom

updateZoom prop => onZoomChange

More clarity of prop versus handler function.
This commit is contained in:
Gazook89
2024-08-17 20:48:30 -05:00
parent 9aa7c67c5b
commit 8be3154865
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
client/homebrew/brewRenderer/brewRenderer.jsx
View File

@@ -224,7 +224,7 @@ const BrewRenderer = (props)=>{
}; };
//Toolbar settings: //Toolbar settings:
const updateZoom = (newZoom) => { const handleZoom = (newZoom) => {
setState((prevState)=>({ setState((prevState)=>({
...prevState, ...prevState,
zoom : newZoom zoom : newZoom
@@ -259,7 +259,7 @@ const BrewRenderer = (props)=>{
contentDidMount={frameDidMount} contentDidMount={frameDidMount}
onClick={()=>{emitClick();}} onClick={()=>{emitClick();}}
> >
<ToolBar updateZoom={updateZoom} currentPage={state.currentPageNumber} onPageChange={handlePageChange} totalPages={rawPages.length}/> <ToolBar onZoomChange={handleZoom} currentPage={state.currentPageNumber} onPageChange={handlePageChange} totalPages={rawPages.length}/>
<div className={'brewRenderer'} <div className={'brewRenderer'}
onScroll={handleScroll} onScroll={handleScroll}
onKeyDown={handleControlKeys} onKeyDown={handleControlKeys}

6
client/homebrew/brewRenderer/toolBar/toolBar.jsx
View File

@@ -6,7 +6,7 @@ const maxZoom = 300;
const minZoom = 10; const minZoom = 10;
const zoomStep = 10; const zoomStep = 10;
const ToolBar = ({ updateZoom, currentPage, onPageChange, totalPages })=>{ const ToolBar = ({ onZoomChange, currentPage, onPageChange, totalPages })=>{
const [state, setState] = useState({ const [state, setState] = useState({
currentPage : currentPage, currentPage : currentPage,
totalPages : totalPages, totalPages : totalPages,
@@ -16,7 +16,7 @@ const ToolBar = ({ updateZoom, currentPage, onPageChange, totalPages })=>{
}); });
useEffect(()=>{ useEffect(()=>{
updateZoom(state.zoomLevel); onZoomChange(state.zoomLevel);
}, [state.zoomLevel]); }, [state.zoomLevel]);
useEffect(()=>{ useEffect(()=>{
@@ -87,7 +87,7 @@ const ToolBar = ({ updateZoom, currentPage, onPageChange, totalPages })=>{
zoomLevel : newZoomLevel, zoomLevel : newZoomLevel,
zoomInput : newZoomLevel, zoomInput : newZoomLevel,
})); }));
updateZoom(newZoomLevel); onZoomChange(newZoomLevel);
} }
}} }}
/> />