From 85cd7c7336ff17a7d0a9c5ebfc5e759e4967e62e Mon Sep 17 00:00:00 2001
From: Trevor Buckner <calculuschild@gmail.com>
Date: Sun, 5 Jan 2025 23:04:48 -0500
Subject: [PATCH] Move calculation of error states outside of render

Our previous approach was technically bad practice to calculate side-effects inside of the render step. We can separate that out as part of this refactor.

Also use native javascript map instead of lodash.
---
 client/homebrew/brewRenderer/errorBar/errorBar.jsx | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/client/homebrew/brewRenderer/errorBar/errorBar.jsx b/client/homebrew/brewRenderer/errorBar/errorBar.jsx
index 9529fa9a4..33e461fa8 100644
--- a/client/homebrew/brewRenderer/errorBar/errorBar.jsx
+++ b/client/homebrew/brewRenderer/errorBar/errorBar.jsx
@@ -1,6 +1,5 @@
 require('./errorBar.less');
 const React = require('react');
-const _ = require('lodash');
 
 import Dialog from '../../../components/dialog.jsx';
 
@@ -9,13 +8,15 @@ const DISMISS_BUTTON = <i className='fas fa-times dismiss' />;
 const ErrorBar = (props)=>{
 	let hasOpenError = false, hasCloseError = false, hasMatchError = false;
 
+	props.errors.map( err => {
+		if(err.id === 'OPEN')     hasOpenError  = true;
+		if(err.id === 'CLOSE')    hasCloseError = true;
+		if(err.id === 'MISMATCH') hasMatchError = true;
+	});
+
 	const renderErrors = ()=>(
 		<ul>
-			{_.map(props.errors, (err, idx)=>{
-				if(err.id === 'OPEN') hasOpenError = true;
-				if(err.id === 'CLOSE') hasCloseError = true;
-				if(err.id === 'MISMATCH') hasMatchError = true;
-				return (
+			{props.errors.map((err, idx)=>{
 					<li key={idx}>
 						Line {err.line} : {err.text}, '{err.type}' tag
 					</li>