f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-09 20:12:41 +00:00
Code Wiki Activity

Fix NaN/undefined showing on first load

Browse Source 
Removes currentPage as a variable since it's been replaced.
This commit is contained in:
Gazook89
2024-10-21 21:27:06 -05:00
parent 183dd63021
commit 822d0c7738
2 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
client/homebrew/brewRenderer/brewRenderer.jsx
View File

@@ -263,9 +263,7 @@ const BrewRenderer = (props)=>{
<> <>
{/*render dummy page while iFrame is mounting.*/} {/*render dummy page while iFrame is mounting.*/}
{!state.isMounted {!state.isMounted
? <div className='brewRenderer' ? <div className='brewRenderer'>
// onScroll={updateCurrentPage}
>
<div className='pages'> <div className='pages'>
{renderDummyPage(1)} {renderDummyPage(1)}
</div> </div>
@@ -287,7 +285,6 @@ const BrewRenderer = (props)=>{
onClick={()=>{emitClick();}} onClick={()=>{emitClick();}}
> >
<div className={`brewRenderer ${global.config.deployment && 'deployment'}`} <div className={`brewRenderer ${global.config.deployment && 'deployment'}`}
// onScroll={updateCurrentPage}
onKeyDown={handleControlKeys} onKeyDown={handleControlKeys}
tabIndex={-1} tabIndex={-1}
style={ styleObject } style={ styleObject }
@@ -298,8 +295,7 @@ const BrewRenderer = (props)=>{
&& &&
<> <>
{renderedStyle} {renderedStyle}
<div className='pages' lang={`${props.lang || 'en'}`} style={{ zoom: `${state.zoom}%` }} <div className='pages' lang={`${props.lang || 'en'}`} style={{ zoom: `${state.zoom}%` }} ref={iframeRef}>
ref={iframeRef}>
{renderedPages} {renderedPages}
</div> </div>
</> </>

8
client/homebrew/brewRenderer/toolBar/toolBar.jsx
View File

@@ -7,10 +7,10 @@ const _ = require('lodash');
const MAX_ZOOM = 300; const MAX_ZOOM = 300;
const MIN_ZOOM = 10; const MIN_ZOOM = 10;
const ToolBar = ({ onZoomChange, currentPage, visiblePages, formattedPages, centerPage, totalPages })=>{ const ToolBar = ({ onZoomChange, visiblePages, formattedPages, centerPage, totalPages })=>{
const [zoomLevel, setZoomLevel] = useState(100); const [zoomLevel, setZoomLevel] = useState(100);
const [pageNum, setPageNum] = useState(null); const [pageNum, setPageNum] = useState(1);
const [toolsVisible, setToolsVisible] = useState(true); const [toolsVisible, setToolsVisible] = useState(true);
useEffect(()=>{ useEffect(()=>{
@@ -23,10 +23,6 @@ const ToolBar = ({ onZoomChange, currentPage, visiblePages, formattedPages, cent
onZoomChange(zoomLevel); onZoomChange(zoomLevel);
}, [zoomLevel]); }, [zoomLevel]);
useEffect(()=>{
setPageNum(currentPage);
}, [currentPage]);
const handleZoomButton = (zoom)=>{ const handleZoomButton = (zoom)=>{
setZoomLevel(_.round(_.clamp(zoom, MIN_ZOOM, MAX_ZOOM))); setZoomLevel(_.round(_.clamp(zoom, MIN_ZOOM, MAX_ZOOM)));
}; };