From 8159c408c8dfdda9c5398d197cf6e3c5a4d49aed Mon Sep 17 00:00:00 2001 From: Trevor Buckner Date: Tue, 24 Dec 2024 00:24:52 -0500 Subject: [PATCH] Move formatVisiblePages After simplifying, this has become a single-line function used in only one place. Can just be placed directly in the one place it is used. --- client/homebrew/brewRenderer/toolBar/toolBar.jsx | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/client/homebrew/brewRenderer/toolBar/toolBar.jsx b/client/homebrew/brewRenderer/toolBar/toolBar.jsx index 598981eaa..ce60971aa 100644 --- a/client/homebrew/brewRenderer/toolBar/toolBar.jsx +++ b/client/homebrew/brewRenderer/toolBar/toolBar.jsx @@ -15,7 +15,9 @@ const ToolBar = ({ displayOptions, onDisplayOptionsChange, visiblePages, totalPa const [toolsVisible, setToolsVisible] = useState(true); useEffect(()=>{ - setPageNum(formatVisiblePages(visiblePages)); + // format multiple visible pages as a range (e.g. "150-153") + const pageRange = visiblePages.length === 1 ? `${visiblePages[0]}` : `${visiblePages[0]} - ${visiblePages.at(-1)}`; + setPageNum(pageRange); }, [visiblePages]); const handleZoomButton = (zoom)=>{ @@ -72,11 +74,6 @@ const ToolBar = ({ displayOptions, onDisplayOptionsChange, visiblePages, totalPa return deltaZoom; }; - // format the visible pages into a range (e.g. "150-153") - const formatVisiblePages = (pages)=>{ - return pages.length === 1 ? `${pages[0]}` : `${pages[0]} - ${pages.at(-1)}`; - }; - return (