From afeadb54173abd91b7d53ab86e8dd438c914982b Mon Sep 17 00:00:00 2001 From: David Bolack Date: Wed, 2 Oct 2024 22:05:09 -0500 Subject: [PATCH 1/5] Enable --experimental-require-module flag on node build in order to support ESM module only modules. --- package.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 482b44965..750e84ec4 100644 --- a/package.json +++ b/package.json @@ -11,10 +11,10 @@ "url": "git://github.com/naturalcrit/homebrewery.git" }, "scripts": { - "dev": "node scripts/dev.js", - "quick": "node scripts/quick.js", - "build": "node scripts/buildHomebrew.js && node scripts/buildAdmin.js", - "builddev": "node scripts/buildHomebrew.js --dev", + "dev": "node --experimental-require-module scripts/dev.js", + "quick": "node --experimental-require-module scripts/quick.js", + "build": "node --experimental-require-module scripts/buildHomebrew.js && node --experimental-require-module scripts/buildAdmin.js", + "builddev": "node --experimental-require-module scripts/buildHomebrew.js --dev", "lint": "eslint --fix", "lint:dry": "eslint", "stylelint": "stylelint --fix **/*.{less}", @@ -37,10 +37,10 @@ "test:hard-breaks": "jest tests/markdown/hard-breaks.test.js --verbose --noStackTrace", "test:emojis": "jest tests/markdown/emojis.test.js --verbose --noStackTrace", "test:route": "jest tests/routes/static-pages.test.js --verbose", - "phb": "node scripts/phb.js", + "phb": "node --experimental-require-module scripts/phb.js", "prod": "set NODE_ENV=production && npm run build", "postinstall": "npm run build", - "start": "node server.js" + "start": "node --experimental-require-module server.js" }, "author": "stolksdorf", "license": "MIT", From fcd1a2de5b6f709ea96583afa801bdf12e8c49c5 Mon Sep 17 00:00:00 2001 From: David Bolack Date: Thu, 3 Oct 2024 09:16:08 -0500 Subject: [PATCH 2/5] Update node version one release. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 750e84ec4..ea6c521fc 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "version": "3.15.0", "engines": { "npm": "^10.2.x", - "node": "^20.8.x" + "node": "^20.9.x" }, "repository": { "type": "git", From a844b29165111d21859fe3c81d93098f4aeaf872 Mon Sep 17 00:00:00 2001 From: David Bolack Date: Thu, 3 Oct 2024 18:40:22 -0500 Subject: [PATCH 3/5] Try further down the updates. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index ea6c521fc..c22526f10 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "version": "3.15.0", "engines": { "npm": "^10.2.x", - "node": "^20.9.x" + "node": "^20.x.x" }, "repository": { "type": "git", From f00e76319cbbce9b24f5a7e86f49b10aed333085 Mon Sep 17 00:00:00 2001 From: David Bolack Date: Thu, 3 Oct 2024 18:44:47 -0500 Subject: [PATCH 4/5] Hard code latest as min --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index c22526f10..faa008422 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "version": "3.15.0", "engines": { "npm": "^10.2.x", - "node": "^20.x.x" + "node": "^20.17.x" }, "repository": { "type": "git", From 5b64052c211329ca9d4164fdc80a1c4ea23a4cc5 Mon Sep 17 00:00:00 2001 From: David Bolack Date: Thu, 3 Oct 2024 18:49:16 -0500 Subject: [PATCH 5/5] Helps if I update the tests. --- .circleci/config.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 274ec25ac..f18f84943 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -10,7 +10,7 @@ orbs: jobs: build: docker: - - image: cimg/node:20.8.0 + - image: cimg/node:20.17.0 - image: mongo:4.4 working_directory: ~/homebrewery @@ -27,7 +27,7 @@ jobs: # fallback to using the latest cache if no exact match is found - v1-dependencies- - - run: sudo npm install -g npm@10.2.0 + - run: sudo npm install -g npm@10.8.2 - node/install-packages: app-dir: ~/homebrewery cache-path: node_modules @@ -45,7 +45,7 @@ jobs: test: docker: - - image: cimg/node:20.8.0 + - image: cimg/node:20.17.0 working_directory: ~/homebrewery parallelism: 1