From 7cc967ad49552afbafd02f5c9f636a572239da52 Mon Sep 17 00:00:00 2001 From: Gazook89 Date: Sat, 17 Aug 2024 23:39:59 -0500 Subject: [PATCH] setZoomLevel to no longer use if/else Remove the 'in'/'out' parameter of the function and just have the buttons send postive or negative integers equal to the desired change in the zoom. No need for if/else statements using strings. --- client/homebrew/brewRenderer/toolBar/toolBar.jsx | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/client/homebrew/brewRenderer/toolBar/toolBar.jsx b/client/homebrew/brewRenderer/toolBar/toolBar.jsx index 8f26db63a..94c8a0dd3 100644 --- a/client/homebrew/brewRenderer/toolBar/toolBar.jsx +++ b/client/homebrew/brewRenderer/toolBar/toolBar.jsx @@ -1,6 +1,7 @@ require('./toolBar.less'); const React = require('react'); const { useState, useEffect } = React; +const _ = require('lodash') const maxZoom = 300; const minZoom = 10; @@ -26,13 +27,8 @@ const ToolBar = ({ onZoomChange, currentPage, onPageChange, totalPages })=>{ })); }, [currentPage]); - const setZoomLevel = (direction)=>{ - let zoomLevel = state.zoomLevel; - if(direction === 'in') { - zoomLevel += zoomStep; - } else { - zoomLevel -= zoomStep; - } + const setZoomLevel = (delta)=>{ + const zoomLevel = _.clamp(state.zoomLevel + delta, minZoom, maxZoom); setState((prevState)=>({ ...prevState, @@ -45,7 +41,7 @@ const ToolBar = ({ onZoomChange, currentPage, onPageChange, totalPages })=>{