From 7bb92bc790efe757a75863d4e4f710fe8c7021b5 Mon Sep 17 00:00:00 2001
From: Trevor Buckner <calculuschild@gmail.com>
Date: Thu, 6 Jun 2024 18:10:04 -0400
Subject: [PATCH] Refactor slightly

---
 client/components/dialog.jsx  | 15 +++------------
 client/components/dialog.less |  6 ------
 2 files changed, 3 insertions(+), 18 deletions(-)
 delete mode 100644 client/components/dialog.less

diff --git a/client/components/dialog.jsx b/client/components/dialog.jsx
index 8f298d571..97884fe5a 100644
--- a/client/components/dialog.jsx
+++ b/client/components/dialog.jsx
@@ -5,25 +5,16 @@ const { useState, useRef, useEffect } = React;
 
 function Dialog({ dismissKey, closeText = 'Close', blocking = false, ...rest }) {
 	const dialogRef = useRef(null);
-	const [open, setOpen] = useState(false);
 
 	useEffect(()=>{
-		if(!localStorage.getItem(dismissKey)) {
-			!open && setOpen(true);
+		if(!dismissKey || !localStorage.getItem(dismissKey)) {
+			blocking ? dialogRef.current?.showModal() : dialogRef.current?.show();
 		}
 	}, []);
 
-	useEffect(()=>{
-		if(open && !dialogRef.current?.open){
-			blocking ? dialogRef.current?.showModal() : dialogRef.current?.show();
-		} else {
-			dialogRef.current?.close();
-		}
-	}, [open]);
-
 	const dismiss = ()=>{
 		dismissKey && localStorage.setItem(dismissKey, true);
-		setOpen(false);
+		dialogRef.current?.close();
 	};
 
 	return <dialog ref={dialogRef} onCancel={dismiss} {...rest}>
diff --git a/client/components/dialog.less b/client/components/dialog.less
deleted file mode 100644
index bbfb40393..000000000
--- a/client/components/dialog.less
+++ /dev/null
@@ -1,6 +0,0 @@
-dialog{
-  &[open]{
-    // Do NOT set a display property on a dialog! Set it on dialog[open] instead
-    display: inline-block;
-  }
-}
\ No newline at end of file