f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-06 12:12:42 +00:00
Code Wiki Activity

fix issue with async setState using Event.persist()

Browse Source
This commit is contained in:
Gazook89
2022-11-05 11:42:21 -05:00
parent edce191c29
commit 78da48b08d
1 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
client/homebrew/editor/metadataEditor/metadataEditor.jsx
View File

@@ -56,6 +56,7 @@ const MetadataEditor = createClass({
}, },
handleFieldChange : function(name, e){ handleFieldChange : function(name, e){
e.persist();
const inputRules = validations[name] ?? []; const inputRules = validations[name] ?? [];
const validationErr = inputRules.map((rule)=>rule(e.target.value)).filter(Boolean); const validationErr = inputRules.map((rule)=>rule(e.target.value)).filter(Boolean);
this.setState((prevState)=>({ this.setState((prevState)=>({
@@ -63,20 +64,22 @@ const MetadataEditor = createClass({
...(prevState.errs ?? {}), ...(prevState.errs ?? {}),
[name] : validationErr.length > 0 ? validationErr : undefined [name] : validationErr.length > 0 ? validationErr : undefined
} }
})); }), ()=>{
if(Object.values(this.state.errs ?? {}).filter(Boolean).length === 0){ if(Object.values(this.state.errs ?? {}).filter(Boolean).length === 0){
e.target.setCustomValidity(''); e.target.setCustomValidity('');
this.props.onChange({ this.props.onChange({
...this.props.metadata, ...this.props.metadata,
[name] : e.target.value [name] : e.target.value
}); });
} else { } else {
const errMessage = this.state.errs[name].map((err)=>{ const errMessage = this.state.errs[name].map((err)=>{
return `- ${err}`; return `- ${err}`;
}).join('\n'); }).join('\n');
e.target.setCustomValidity(errMessage); e.target.setCustomValidity(errMessage);
e.target.reportValidity(); e.target.reportValidity();
}; };
});
}, },