From 7506a870d577ac14d9bebc3f2cabbf8af24bfdf4 Mon Sep 17 00:00:00 2001 From: Trevor Buckner Date: Wed, 18 Nov 2026 19:44:45 +0000 Subject: [PATCH] Simplify tag filtering logic --- .../pages/basePages/listPage/listPage.jsx | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/client/homebrew/pages/basePages/listPage/listPage.jsx b/client/homebrew/pages/basePages/listPage/listPage.jsx index 8b5da0997..d986a674e 100644 --- a/client/homebrew/pages/basePages/listPage/listPage.jsx +++ b/client/homebrew/pages/basePages/listPage/listPage.jsx @@ -202,18 +202,10 @@ const ListPage = ({ brewCollection = [{ title: '', class: '', brews: [] }], navI const filterTextTest = brewStrings.includes(testString); // Filter by user selected tags - let filterTagTest = true; - if(filterTags.length > 0) { - filterTagTest = - Array.isArray(brew.tags) && - filterTags?.every((tag)=>{ - return ( - brew.tags.findIndex((brewTag)=>{ - return brewTag.toLowerCase() == tag.toLowerCase(); - }) >= 0 - ); - }); - } + const filterTagTest = filterTags.every((tag)=>{ + Array.isArray(brew.tags) && //TODO: brew.tags should be converted to array at load so we don't have to catch it here + brew.tags.some((brewTag)=>brewTag.toLowerCase() == tag.toLowerCase())} + ); return filterTextTest && filterTagTest; });