f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-23 14:23:21 +00:00
Code Wiki Activity

Memoize BrewRenderer

Browse Source 
Only re-render BrewRenderer when specific props have changed.

Fixes lag during scrolling, which updates the "currentPage" prop, but isn't actually used until the text is changed.
This commit is contained in:
Trevor Buckner
2024-10-14 21:55:02 -04:00
parent f1af87ee7e
commit 72b69ebb6a
1 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
client/homebrew/brewRenderer/brewRenderer.jsx
View File

@@ -1,7 +1,7 @@
/*eslint max-lines: ["warn", {"max": 300, "skipBlankLines": true, "skipComments": true}]*/
require('./brewRenderer.less');
const React = require('react');
const { useState, useRef, useCallback } = React;
const { useState, useRef, useCallback, memo } = React;
const _ = require('lodash');
const MarkdownLegacy = require('naturalcrit/markdownLegacy.js');
@@ -47,7 +47,7 @@ const BrewPage = (props)=>{
const renderedPages = [];
let rawPages = [];
const BrewRenderer = (props)=>{
const BrewRenderer = memo((props)=>{
props = {
text : '',
style : '',
@@ -224,6 +224,19 @@ const BrewRenderer = (props)=>{
</Frame>
</>
);
};
}, arePropsEqual);
//Only re-render brewRenderer if arePropsEqual == true
function arePropsEqual(oldProps, newProps) {
return (
oldProps.text.length === newProps.text.length &&
oldProps.style.length === newProps.style.length &&
oldProps.renderer === newProps.renderer &&
oldProps.theme === newProps.theme &&
oldProps.errors === newProps.errors &&
oldProps.themeBundle === newProps.themeBundle &&
oldProps.lang === newProps.lang
);
}
module.exports = BrewRenderer;