f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-08 03:12:40 +00:00
Code Wiki Activity

don't save errs to state

Browse Source
This commit is contained in:
Gazook89
2022-11-13 12:56:17 -06:00
parent 4f762b376f
commit 6a0d8d13b0
1 changed files with 18 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
client/homebrew/editor/metadataEditor/metadataEditor.jsx
View File

@@ -57,14 +57,12 @@ const MetadataEditor = createClass({
handleFieldChange : function(name, e){ handleFieldChange : function(name, e){
e.persist(); e.persist();
// load validation rules, and check input value against them
const inputRules = validations[name] ?? []; const inputRules = validations[name] ?? [];
const validationErr = inputRules.map((rule)=>rule(e.target.value)).filter(Boolean); const validationErr = inputRules.map((rule)=>rule(e.target.value)).filter(Boolean);
this.setState((prevState)=>({
errs : { // if no validation rules, save to props
...(prevState.errs ?? {}),
[name] : validationErr.length > 0 ? validationErr : undefined
}
}), ()=>{
if(validationErr.length === 0){ if(validationErr.length === 0){
e.target.setCustomValidity(''); e.target.setCustomValidity('');
this.props.onChange({ this.props.onChange({
@@ -72,15 +70,14 @@ const MetadataEditor = createClass({
[name] : e.target.value [name] : e.target.value
}); });
} else { } else {
const errMessage = this.state.errs[name].map((err)=>{ // if validation issues, display built-in browser error popup with each error.
console.log(validationErr);
const errMessage = validationErr.map((err)=>{
return `- ${err}`; return `- ${err}`;
}).join('\n'); }).join('\n');
e.target.setCustomValidity(errMessage); e.target.setCustomValidity(errMessage);
e.target.reportValidity(); e.target.reportValidity();
}; };
});
}, },
handleSystem : function(system, e){ handleSystem : function(system, e){