f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-09 18:02:39 +00:00
Code Wiki Activity

Rearranged to avoid obscuring the state

Browse Source 
`output` variable added an unneeded layer to dig through to understand what is being saved to `setState()`
This commit is contained in:
Trevor Buckner
2023-08-21 12:08:54 -04:00
parent 8c975747c4
commit 6130d69906
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
client/homebrew/pages/newPage/newPage.jsx
View File

@@ -50,7 +50,6 @@ const NewPage = createClass({
document.addEventListener('keydown', this.handleControlKeys); document.addEventListener('keydown', this.handleControlKeys);
const brew = this.state.brew; const brew = this.state.brew;
const output = {};
if(!this.props.brew.shareId && typeof window !== 'undefined') { //Load from localStorage if in client browser if(!this.props.brew.shareId && typeof window !== 'undefined') { //Load from localStorage if in client browser
const brewStorage = localStorage.getItem(BREWKEY); const brewStorage = localStorage.getItem(BREWKEY);
@@ -64,15 +63,15 @@ const NewPage = createClass({
brew.renderer = metaStorage?.renderer ?? brew.renderer; brew.renderer = metaStorage?.renderer ?? brew.renderer;
brew.theme = metaStorage?.theme ?? brew.theme; brew.theme = metaStorage?.theme ?? brew.theme;
brew.lang = metaStorage?.lang ?? brew.lang; brew.lang = metaStorage?.lang ?? brew.lang;
output.brew = brew;
} }
SAVEKEY = `HOMEBREWERY-DEFAULT-SAVE-LOCATION-${global.account?.username || ''}`; SAVEKEY = `HOMEBREWERY-DEFAULT-SAVE-LOCATION-${global.account?.username || ''}`;
const saveStorage = localStorage.getItem(SAVEKEY) || 'HOMEBREWERY'; const saveStorage = localStorage.getItem(SAVEKEY) || 'HOMEBREWERY';
output.saveGoogle = (saveStorage == 'GOOGLE-DRIVE' && this.state.saveGoogle);
this.setState(output); this.setState({
brew : brew,
saveGoogle : (saveStorage == 'GOOGLE-DRIVE' && this.state.saveGoogle)
});
localStorage.setItem(BREWKEY, brew.text); localStorage.setItem(BREWKEY, brew.text);
if(brew.style) if(brew.style)