f.weber/homebrewery
0
0
Fork 0
mirror of https://github.com/naturalcrit/homebrewery.git synced 2026-01-06 14:22:52 +00:00
Code Wiki Activity

Change filter to some

Browse Source 
`some` stops once it finds a true case; `filter` has to process the whole list of folds first.
This commit is contained in:
Trevor Buckner
2024-08-26 17:23:44 -04:00
parent d59c6be359
commit 5671728c97
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
client/homebrew/editor/editor.jsx
View File

@@ -160,11 +160,8 @@ const Editor = createClass({
// Don't process lines inside folded text // Don't process lines inside folded text
// If the current lineNumber is inside any folded marks, skip line styling // If the current lineNumber is inside any folded marks, skip line styling
if(_.filter(foldLines, (fold)=>{ if (foldLines.some(fold => lineNumber >= fold.from && lineNumber <= fold.to))
return lineNumber >= fold.from && lineNumber <= fold.to;
}).length > 0) {
return; return;
};
// Styling for \page breaks // Styling for \page breaks
if((this.props.renderer == 'legacy' && line.includes('\\page')) || if((this.props.renderer == 'legacy' && line.includes('\\page')) ||
@@ -278,7 +275,7 @@ const Editor = createClass({
// Iterate over conflicting marks and clear them // Iterate over conflicting marks and clear them
var marks = codeMirror.findMarks(startPos, endPos); var marks = codeMirror.findMarks(startPos, endPos);
marks.forEach(function(marker) { marks.forEach(function(marker) {
marker.clear(); if(!marker.__isFold) marker.clear();
}); });
codeMirror.markText(startPos, endPos, { className: 'emoji' }); codeMirror.markText(startPos, endPos, { className: 'emoji' });
} }