From 510d8f410dbbe78120f72c272af3697391e1bc34 Mon Sep 17 00:00:00 2001 From: David Bolack Date: Mon, 3 Jun 2024 22:45:22 -0500 Subject: [PATCH] Resolve timing issue with liveScroll on linking. Checks to see if prevProps.livescroll has a proper Bool value. If not, do not brewJump() in editor.componantSDidUpdate. --- client/homebrew/editor/editor.jsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/client/homebrew/editor/editor.jsx b/client/homebrew/editor/editor.jsx index 147170023..06375d21d 100644 --- a/client/homebrew/editor/editor.jsx +++ b/client/homebrew/editor/editor.jsx @@ -105,7 +105,7 @@ const Editor = createClass({ this.sourceJump(); }; if(prevProps.liveScroll != this.props.liveScroll) { - if (this.props.liveScroll) this.brewJump(); + if ((prevProps.liveScroll != undefined) && (this.props.liveScroll)) this.brewJump(); }; }, @@ -328,7 +328,6 @@ const Editor = createClass({ // console.log(`Scroll to: p${targetPage}`); const brewRenderer = window.frames['BrewRenderer'].contentDocument.getElementsByClassName('brewRenderer')[0]; const currentPos = brewRenderer.scrollTop; - if(!window.frames['BrewRenderer'].contentDocument.getElementById(`p${targetPage}`)) return; const targetPos = window.frames['BrewRenderer'].contentDocument.getElementById(`p${targetPage}`).getBoundingClientRect().top; const interimPos = targetPos >= 0 ? -30 : 30;