diff --git a/.gitignore b/.gitignore index ecd6009b6..150d81008 100644 --- a/.gitignore +++ b/.gitignore @@ -12,3 +12,5 @@ todo.md startDB.bat startMViewer.bat .vscode + +coverage diff --git a/changelog.md b/changelog.md index 3e6216607..10899a485 100644 --- a/changelog.md +++ b/changelog.md @@ -61,6 +61,16 @@ pre { ## changelog For a full record of development, visit our [Github Page](https://github.com/naturalcrit/homebrewery). +### Saturday 18/02/2023 - v3.6.1 +{{taskList +##### G-Ambatte + +* [x] Fix users not being removed from Authors list correctly + +Fixes issues [#2674](https://github.com/naturalcrit/homebrewery/issues/2674) +}} + + ### Friday 23/01/2023 - v3.6.0 {{taskList ##### calculuschild diff --git a/server/homebrew.api.js b/server/homebrew.api.js index f531bdcf9..6f5fcb1ef 100644 --- a/server/homebrew.api.js +++ b/server/homebrew.api.js @@ -317,8 +317,7 @@ If you believe you should have access to this brew, ask the file owner to invite brew.textBin = zlib.deflateRawSync(brew.text); brew.text = undefined; } - - // Otherwise, save the brew with updated author list + brew.markModified('authors'); //Mongo will not properly update arrays without markModified() await brew.save() .catch((err)=>{ throw { status: 500, message: err }; diff --git a/server/homebrew.api.spec.js b/server/homebrew.api.spec.js index 22f80155c..3f3eb9794 100644 --- a/server/homebrew.api.spec.js +++ b/server/homebrew.api.spec.js @@ -11,6 +11,7 @@ describe('Tests for api', ()=>{ let modelBrew; let saveFunc; let removeFunc; + let markModifiedFunc; let saved; beforeEach(()=>{ @@ -20,15 +21,18 @@ describe('Tests for api', ()=>{ return saved; }); removeFunc = jest.fn(async function() {}); + markModifiedFunc = jest.fn(()=>true); modelBrew = (brew)=>({ ...brew, - save : saveFunc, - remove : removeFunc, - toObject : function() { + save : saveFunc, + remove : removeFunc, + markModified : markModifiedFunc, + toObject : function() { delete this.save; delete this.toObject; delete this.remove; + delete this.markModified; return this; } }); @@ -627,6 +631,7 @@ brew`); await api.deleteBrew(req, res); expect(api.getBrew).toHaveBeenCalled(); + expect(markModifiedFunc).toHaveBeenCalled(); expect(model.findOne).toHaveBeenCalled(); expect(removeFunc).not.toHaveBeenCalled(); expect(saveFunc).toHaveBeenCalled(); @@ -716,6 +721,7 @@ brew`); await api.deleteBrew(req, res); expect(api.getBrew).toHaveBeenCalled(); + expect(markModifiedFunc).toHaveBeenCalled(); expect(model.findOne).toHaveBeenCalled(); expect(removeFunc).not.toHaveBeenCalled(); expect(api.deleteGoogleBrew).toHaveBeenCalled();